* [patch] video/mbx: indent some if statements
@ 2014-06-11 6:45 Dan Carpenter
2014-06-23 11:51 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-06-11 6:45 UTC (permalink / raw)
To: linux-fbdev
Checkpatch.pl worries that we have left off the conditional bit because
it isn't indented correctly.
WARNING: suspect code indent for conditional statements (24, 24)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/video/fbdev/mbx/mbxfb.c b/drivers/video/fbdev/mbx/mbxfb.c
index 2bd52ed..698df954 100644
--- a/drivers/video/fbdev/mbx/mbxfb.c
+++ b/drivers/video/fbdev/mbx/mbxfb.c
@@ -628,14 +628,14 @@ static int mbxfb_ioctl(struct fb_info *info, unsigned int cmd,
case MBXFB_IOCS_PLANEORDER:
if (copy_from_user(&porder, (void __user*)arg,
sizeof(struct mbxfb_planeorder)))
- return -EFAULT;
+ return -EFAULT;
return mbxfb_ioctl_planeorder(&porder);
case MBXFB_IOCS_ALPHA:
if (copy_from_user(&alpha, (void __user*)arg,
sizeof(struct mbxfb_alphaCtl)))
- return -EFAULT;
+ return -EFAULT;
return mbxfb_ioctl_alphactl(&alpha);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] video/mbx: indent some if statements
2014-06-11 6:45 [patch] video/mbx: indent some if statements Dan Carpenter
@ 2014-06-23 11:51 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2014-06-23 11:51 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
On 11/06/14 09:45, Dan Carpenter wrote:
> Checkpatch.pl worries that we have left off the conditional bit because
> it isn't indented correctly.
>
> WARNING: suspect code indent for conditional statements (24, 24)
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/video/fbdev/mbx/mbxfb.c b/drivers/video/fbdev/mbx/mbxfb.c
> index 2bd52ed..698df954 100644
> --- a/drivers/video/fbdev/mbx/mbxfb.c
> +++ b/drivers/video/fbdev/mbx/mbxfb.c
> @@ -628,14 +628,14 @@ static int mbxfb_ioctl(struct fb_info *info, unsigned int cmd,
> case MBXFB_IOCS_PLANEORDER:
> if (copy_from_user(&porder, (void __user*)arg,
> sizeof(struct mbxfb_planeorder)))
> - return -EFAULT;
> + return -EFAULT;
>
> return mbxfb_ioctl_planeorder(&porder);
>
> case MBXFB_IOCS_ALPHA:
> if (copy_from_user(&alpha, (void __user*)arg,
> sizeof(struct mbxfb_alphaCtl)))
> - return -EFAULT;
> + return -EFAULT;
>
> return mbxfb_ioctl_alphactl(&alpha);
>
>
Thanks, queued for 3.17.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-23 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-11 6:45 [patch] video/mbx: indent some if statements Dan Carpenter
2014-06-23 11:51 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).