From: Varka Bhadram <varkabhadram@gmail.com>
To: Daniel Jeong <gshark.jeong@gmail.com>,
Jingoo Han <jg1.han@samsung.com>, Bryan Wu <cooloney@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>
Cc: Daniel Jeong <daniel.jeong@ti.com>,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [RFC v5 1/2] backlight: add new tps611xx backlight driver
Date: Tue, 15 Jul 2014 10:37:05 +0000 [thread overview]
Message-ID: <53C50181.3060302@gmail.com> (raw)
In-Reply-To: <1405418958-7596-2-git-send-email-gshark.jeong@gmail.com>
On 07/15/2014 03:39 PM, Daniel Jeong wrote:
(...)
> +
> +static int tps611xx_backlight_remove(struct platform_device *pdev)
> +{
> + struct tps611xx_bl_data *pchip = platform_get_drvdata(pdev);
> + const struct tps611xx_esdata *esdata = pchip->esdata;
> +
> + device_remove_file(&(pchip->bled->dev), &dev_attr_enable);
> + gpio_direction_output(pchip->en_gpio, 0);
> + mdelay(esdata->time.reset);
> + return 0;
> +}
> +
Better to move the of_device_ids also here... We can see of_match_table directly...
> +static const struct platform_device_id tps611xx_id_table[] = {
> + {TPS61158_NAME, (unsigned long)&tps611xx_info[TPS61158_ID]},
> + {TPS61161_NAME, (unsigned long)&tps611xx_info[TPS61161_ID]},
> + {TPS61163_NAME, (unsigned long)&tps611xx_info[TPS61163_ID]},
> + {TPS61165_NAME, (unsigned long)&tps611xx_info[TPS61165_ID]},
> + {}
> +};
> +
> +static struct platform_driver tps611xx_backlight_driver = {
> + .driver = {
> + .name = TPS611XX_NAME,
> + .owner = THIS_MODULE,
No need to update .owner
see:http://lxr.free-electrons.com/source/include/linux/platform_device.h#L190
--
Regards,
Varka Bhadram.
next prev parent reply other threads:[~2014-07-15 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 10:09 [RFC v5 0/2] backlight: add new tps611xx backlight driver Daniel Jeong
2014-07-15 10:09 ` [RFC v5 1/2] " Daniel Jeong
2014-07-15 10:37 ` Varka Bhadram [this message]
2014-07-15 10:09 ` [RFC v5 2/2] backlight: device tree: add new tps611xx backlight binding Daniel Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C50181.3060302@gmail.com \
--to=varkabhadram@gmail.com \
--cc=cooloney@gmail.com \
--cc=daniel.jeong@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gshark.jeong@gmail.com \
--cc=jg1.han@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).