* Re: [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver
[not found] ` <1405197014-25225-4-git-send-email-berthe.ab@gmail.com>
@ 2014-07-22 15:08 ` Linus Walleij
2014-07-29 11:30 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2014-07-22 15:08 UTC (permalink / raw)
To: abdoulaye berthe, arm@kernel.org, Ralf Baechle,
Benjamin Herrenschmidt, Rafał Miłecki, Jiri Kosina,
Dmitry Torokhov, Bryan Wu, Mauro Carvalho Chehab, Lee Jones,
Samuel Ortiz, Matthew Garrett, Michael Buesch, Greg KH,
Tomi Valkeinen, Mark Brown, Liam Girdwood
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips,
linux-sh@vger.kernel.org, Linux Input,
linux-media@vger.kernel.org, linux-serial@vger.kernel.org,
linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org
On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe <berthe.ab@gmail.com> wrote:
Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be
applied. We're getting rid of the return value from gpiochip_remove().
> this remove all reference to gpio_remove retval in all driver
> except pinctrl and gpio. the same thing is done for gpio and
> pinctrl in two different patches.
>
> Signed-off-by: abdoulaye berthe <berthe.ab@gmail.com>
(...)
I think this patch probably needs to be broken down per-subsystem as it
hits all over the map. But let's start requesting ACKs for the
individual pieces.
Actually I think it will be OK to merge because there is likely not much churn
around these code sites.
I'm a bit torn between just wanting a big patch for this hitting drivers/gpio
and smaller patches hitting one subsystem at a time. We should be able
to hammer this in one switch strike.
> arch/arm/common/scoop.c | 10 ++--------
ARM SoC folks, can you ACK this?
> arch/mips/txx9/generic/setup.c | 4 ++--
Ralf can you ACK this?
> arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 3 ++-
Benji, can you ACK this?
> arch/sh/boards/mach-x3proto/gpio.c | 6 ++----
Aha noone can ACK this, whatever...
> drivers/bcma/driver_gpio.c | 3 ++-
Rafał can you ACK this?
> drivers/hid/hid-cp2112.c | 6 ++----
Jiri can you ACK this?
> drivers/input/keyboard/adp5588-keys.c | 4 +---
> drivers/input/keyboard/adp5589-keys.c | 4 +---
> drivers/input/touchscreen/ad7879.c | 10 +++-------
Dmitry can you ACK this?
> drivers/leds/leds-pca9532.c | 10 ++--------
> drivers/leds/leds-tca6507.c | 7 ++-----
Bryan can you ACK this?
> drivers/media/dvb-frontends/cxd2820r_core.c | 10 +++-------
Mauro can you ACK this?
(Hm that looks weird. Mental note to look closer at this.)
> drivers/mfd/asic3.c | 3 ++-
> drivers/mfd/htc-i2cpld.c | 8 +-------
> drivers/mfd/sm501.c | 17 +++--------------
> drivers/mfd/tc6393xb.c | 13 ++++---------
> drivers/mfd/ucb1x00-core.c | 8 ++------
Lee/Sam can either of you ACK this?
> drivers/pinctrl/pinctrl-abx500.c | 15 +++------------
> drivers/pinctrl/pinctrl-exynos5440.c | 6 +-----
> drivers/pinctrl/pinctrl-msm.c | 10 +++-------
> drivers/pinctrl/pinctrl-nomadik.c | 2 +-
> drivers/pinctrl/pinctrl-samsung.c | 14 ++++----------
Abdoulaye: these should be in the other patch for pinctrl.
> drivers/platform/x86/intel_pmic_gpio.c | 3 +--
Matthew can you ACK this?
> drivers/ssb/driver_gpio.c | 3 ++-
Michael can you (A) ACK this and
(B) think of moving this driver to drivers/gpio... Patches welcome.
> drivers/staging/vme/devices/vme_pio2_gpio.c | 4 +---
> drivers/tty/serial/max310x.c | 10 ++++------
Greg can you ACK this?
> drivers/video/fbdev/via/via-gpio.c | 10 +++-------
Tomi can you ACK this?
> sound/soc/codecs/wm5100.c | 5 +----
> sound/soc/codecs/wm8903.c | 6 +-----
> sound/soc/codecs/wm8962.c | 5 +----
> sound/soc/codecs/wm8996.c | 6 +-----
Liam || Mark can you ACK this?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread