linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: ARM CLCD: Fix DT-related build problems
Date: Mon, 04 Aug 2014 06:38:01 +0000	[thread overview]
Message-ID: <53DF2A49.9080609@ti.com> (raw)
In-Reply-To: <1406904214-7360-1-git-send-email-pawel.moll@arm.com>

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]

On 01/08/14 17:43, Pawel Moll wrote:
> This patch fixes the following error when !CONFIG_OF:
> 
> drivers/video/fbdev/amba-clcd.c:800:54: warning: ‘struct amba_dev’ declared inside parameter list [enabled by default]
>  static struct clcd_board *clcdfb_of_get_board(struct amba_dev *dev)
>                                                       ^
> and adds a missing Kconfig select causing this
> when CONFIG_OF && !CONFIG_FB_MODE_HELPERS:
> 
> drivers/video/fbdev/amba-clcd.c:567: undefined reference to `fb_videomode_from_videomode'
> 
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>
> ---
> 
> Hi Tomi,
> 
> This fixes two small problems detected in next by the kbuild test robot
> (thanks, Fengguang!) Hope you can apply it before the merge window.

Thanks, applied.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2014-08-04  6:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 14:43 [PATCH] video: ARM CLCD: Fix DT-related build problems Pawel Moll
2014-08-04  6:38 ` Tomi Valkeinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DF2A49.9080609@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).