From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Pranith Kumar <bobby.prani@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Arnd Bergmann <arnd@arndb.de>,
Peter Griffin <peter.griffin@linaro.org>,
Alexander Shiyan <shc_work@mail.ru>,
Jean Delvare <jdelvare@suse.de>,
Kukjin Kim <kgene.kim@samsung.com>,
Mark Brown <broonie@linaro.org>,
FRAMEBUFFER LAYER <linux-fbdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] powerpc: Fix build error for vga16fb
Date: Tue, 26 Aug 2014 10:02:11 +0000 [thread overview]
Message-ID: <53FC5B23.3000205@ti.com> (raw)
In-Reply-To: <CAMuHMdV_vAPCPh1JdCxtf0iz6haHULUV8t0oYt0jrEAky2WSLw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]
On 19/08/14 00:28, Geert Uytterhoeven wrote:
> Hi Pranith,
>
> On Mon, Aug 18, 2014 at 11:13 PM, Pranith Kumar <bobby.prani@gmail.com> wrote:
>> Fix a build error caused by
>>
>> drivers/built-in.o: In function `vga16fb_probe':
>> drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base'
>> drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base'
>> make: *** [vmlinux] Error 1
>>
>> This is occuring as vgacon_remap_base is exported only when
>> CONFIG_VGA_CONSOLE=y. Fix the error by making FB_VBA16 depend on
>> CONFIG_VGA_CONSOLE.
>>
>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> CC: Andrew Morton <akpm@linux-foundation.org>
>> ---
>> drivers/video/fbdev/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
>> index e911b9c..09df564 100644
>> --- a/drivers/video/fbdev/Kconfig
>> +++ b/drivers/video/fbdev/Kconfig
>> @@ -547,7 +547,7 @@ config FB_IMSTT
>>
>> config FB_VGA16
>> tristate "VGA 16-color graphics support"
>> - depends on FB && (X86 || PPC)
>> + depends on FB && (X86 || PPC) && CONFIG_VGA_CONSOLE
>
> The dependency on CONFIG_VGA_CONSOLE only exists on PPC, not on x86.
> So this is not correct.
>
> Digging a bit deeper: There's no code left in arch/powerpc that actually
> sets vgacon_remap_base, so it's not gonna work anyway.
> It seems vga16 support on PPC died with the removal of arch/ppc/.
Hmm, so I wonder if vga16fb is supposed to work on ppc or not. Pranith's
follow-up patch disables vga16fb for PPC, which obviously fixes the
compilation problem, but is that really a correct fix?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-08-26 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1408396422-32658-1-git-send-email-bobby.prani@gmail.com>
2014-08-18 21:13 ` [PATCH] powerpc: Fix build error for vga16fb Pranith Kumar
2014-08-18 21:28 ` Geert Uytterhoeven
2014-08-18 21:34 ` Pranith Kumar
2014-08-26 10:02 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC5B23.3000205@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bobby.prani@gmail.com \
--cc=broonie@linaro.org \
--cc=geert@linux-m68k.org \
--cc=jdelvare@suse.de \
--cc=kgene.kim@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peter.griffin@linaro.org \
--cc=plagnioj@jcrosoft.com \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).