* [PATCH V2] video : remove redundant error check
@ 2014-05-16 9:31 Daeseok Youn
2014-08-26 10:34 ` Tomi Valkeinen
0 siblings, 1 reply; 3+ messages in thread
From: Daeseok Youn @ 2014-05-16 9:31 UTC (permalink / raw)
To: plagnioj
Cc: tomi.valkeinen, jg1.han, laurent.pinchart, robdclark,
daniel.vetter, Julia.Lawall, linux-fbdev, linux-kernel
It doesn't need to check "err" for printing info.
And also use pr_info instead of printk.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
V2: removes unneeded lines for sending a patch
drivers/video/fbdev/i810/i810_main.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
index bb674e4..15cb397 100644
--- a/drivers/video/fbdev/i810/i810_main.c
+++ b/drivers/video/fbdev/i810/i810_main.c
@@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info *info)
for (i = 0; i < par->ddc_num + 1; i++) {
err = i810_probe_i2c_connector(info, &par->edid, i);
- if (!err)
+ if (!err) {
+ pr_info("i810fb_init_pci: DDC probe successful\n");
break;
+ }
}
- if (!err)
- printk("i810fb_init_pci: DDC probe successful\n");
-
fb_edid_to_monspecs(par->edid, specs);
if (specs->modedb = NULL)
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V2] video : remove redundant error check
2014-05-16 9:31 [PATCH V2] video : remove redundant error check Daeseok Youn
@ 2014-08-26 10:34 ` Tomi Valkeinen
2014-08-27 10:00 ` DaeSeok Youn
0 siblings, 1 reply; 3+ messages in thread
From: Tomi Valkeinen @ 2014-08-26 10:34 UTC (permalink / raw)
To: Daeseok Youn, plagnioj, Antonino Daplas
Cc: jg1.han, laurent.pinchart, robdclark, daniel.vetter, Julia.Lawall,
linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]
On 16/05/14 12:31, Daeseok Youn wrote:
> It doesn't need to check "err" for printing info.
> And also use pr_info instead of printk.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> V2: removes unneeded lines for sending a patch
>
> drivers/video/fbdev/i810/i810_main.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
> index bb674e4..15cb397 100644
> --- a/drivers/video/fbdev/i810/i810_main.c
> +++ b/drivers/video/fbdev/i810/i810_main.c
> @@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info *info)
>
> for (i = 0; i < par->ddc_num + 1; i++) {
> err = i810_probe_i2c_connector(info, &par->edid, i);
> - if (!err)
> + if (!err) {
> + pr_info("i810fb_init_pci: DDC probe successful\n");
> break;
> + }
> }
>
> - if (!err)
> - printk("i810fb_init_pci: DDC probe successful\n");
> -
> fb_edid_to_monspecs(par->edid, specs);
>
> if (specs->modedb == NULL)
>
I don't know... I think I personally like more the original version. In
fact, the whole print looks quite useless to me, or at least it should
be a debug print.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V2] video : remove redundant error check
2014-08-26 10:34 ` Tomi Valkeinen
@ 2014-08-27 10:00 ` DaeSeok Youn
0 siblings, 0 replies; 3+ messages in thread
From: DaeSeok Youn @ 2014-08-27 10:00 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: Jean-Christophe PLAGNIOL-VILLARD, Antonino Daplas, jg1.han,
laurent.pinchart, Rob Clark, daniel.vetter, Julia Lawall,
linux-fbdev, linux-kernel
Hi,
2014-08-26 19:34 GMT+09:00 Tomi Valkeinen <tomi.valkeinen@ti.com>:
> On 16/05/14 12:31, Daeseok Youn wrote:
>> It doesn't need to check "err" for printing info.
>> And also use pr_info instead of printk.
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>> ---
>> V2: removes unneeded lines for sending a patch
>>
>> drivers/video/fbdev/i810/i810_main.c | 7 +++----
>> 1 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
>> index bb674e4..15cb397 100644
>> --- a/drivers/video/fbdev/i810/i810_main.c
>> +++ b/drivers/video/fbdev/i810/i810_main.c
>> @@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info *info)
>>
>> for (i = 0; i < par->ddc_num + 1; i++) {
>> err = i810_probe_i2c_connector(info, &par->edid, i);
>> - if (!err)
>> + if (!err) {
>> + pr_info("i810fb_init_pci: DDC probe successful\n");
>> break;
>> + }
>> }
>>
>> - if (!err)
>> - printk("i810fb_init_pci: DDC probe successful\n");
>> -
>> fb_edid_to_monspecs(par->edid, specs);
>>
>> if (specs->modedb = NULL)
>>
>
> I don't know... I think I personally like more the original version. In
> fact, the whole print looks quite useless to me, or at least it should
> be a debug print.
Yes. this patch doesn't need.
Thanks for review.
regards,
Daeseok Youn.
>
> Tomi
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-27 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-16 9:31 [PATCH V2] video : remove redundant error check Daeseok Youn
2014-08-26 10:34 ` Tomi Valkeinen
2014-08-27 10:00 ` DaeSeok Youn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).