From: "John B. Wyatt IV" <jbwyatt4@gmail.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Julia Lawall <julia.lawall@inria.fr>,
outreachy-kernel@googlegroups.com,
Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>,
Soumyajit Deb <debsoumyajit100@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH] staging: fbtft: Replace udelay with preferred usleep_range
Date: Mon, 30 Mar 2020 22:03:55 +0000 [thread overview]
Message-ID: <53befe00af657428b591200b31b5349a4a462eb1.camel@gmail.com> (raw)
In-Reply-To: <20200330194043.56c79bb8@elisabeth>
On Mon, 2020-03-30 at 19:40 +0200, Stefano Brivio wrote:
> On Sun, 29 Mar 2020 12:37:18 +0200 (CEST)
> Julia Lawall <julia.lawall@inria.fr> wrote:
>
> > On Sun, 29 Mar 2020, Soumyajit Deb wrote:
> >
> > > I had the same doubt the other day about the replacement of
> > > udelay() with
> > > usleep_range(). The corresponding range for the single argument
> > > value of
> > > udelay() is quite confusing as I couldn't decide the range. But
> > > as much as I
> > > noticed checkpatch.pl gives warning for replacing udelay() with
> > > usleep_range() by checking the argument value of udelay(). In the
> > > documentation, it is written udelay() should be used for a sleep
> > > time of at
> > > most 10 microseconds but between 10 microseconds and 20
> > > milliseconds,
> > > usleep_range() should be used.
> > > I think the range is code specific and will depend on what range
> > > is
> > > acceptable and doesn't break the code.
> > > Please correct me if I am wrong.
> >
> > The range depends on the associated hardware.
>
> John, by the way, here you could have checked the datasheet of this
> LCD
> controller. It's a pair of those:
> https://www.sparkfun.com/datasheets/LCD/ks0108b.pdf
>
No I have not. This datasheet is a little over my head honestly.
What would you recommend to get familiar with datasheets like this?
next prev parent reply other threads:[~2020-03-30 22:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 9:22 [PATCH] staging: fbtft: Replace udelay with preferred usleep_range John B. Wyatt IV
2020-03-29 9:28 ` [Outreachy kernel] " Julia Lawall
2020-03-29 9:38 ` John Wyatt
2020-03-29 9:47 ` Julia Lawall
[not found] ` <CAMS7mKBEhqFat8fWi=QiFwfLV9+skwi1hE-swg=XxU48zk=_tQ@mail.gmail.com>
2020-03-29 10:37 ` Julia Lawall
2020-03-29 10:51 ` Sam Muhammed
2020-03-29 12:22 ` Andy Shevchenko
2020-03-30 17:40 ` Stefano Brivio
2020-03-30 22:03 ` John B. Wyatt IV [this message]
2020-03-30 22:16 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53befe00af657428b591200b31b5349a4a462eb1.camel@gmail.com \
--to=jbwyatt4@gmail.com \
--cc=debsoumyajit100@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=payal.s.kshirsagar.98@gmail.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).