From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: ARM CLCD: Fix color model capabilities for DT platforms
Date: Fri, 12 Sep 2014 08:50:55 +0000 [thread overview]
Message-ID: <5412B3EF.9090604@ti.com> (raw)
In-Reply-To: <1410358553-2344-1-git-send-email-pawel.moll@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]
On 10/09/14 17:15, Pawel Moll wrote:
> The DT-based panel capabilities selection was picking up
> a subset of available modes based on hardware configuration.
> This was wrong, as the capabilities describe available
> memory models and adapt the display controller to them
> that the RGB output is wired up correctly (as in: R and
> B components are not swapped).
>
> This patch fixes it by removing the unnecessary limitation.
>
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>
> ---
> drivers/video/fbdev/amba-clcd.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
> index a7b6217..6ad23bd 100644
> --- a/drivers/video/fbdev/amba-clcd.c
> +++ b/drivers/video/fbdev/amba-clcd.c
> @@ -639,9 +639,7 @@ static int clcdfb_of_init_tft_panel(struct clcd_fb *fb, u32 r0, u32 g0, u32 b0)
> if (g0 != panels[i].g0)
> continue;
> if (r0 == panels[i].r0 && b0 == panels[i].b0)
> - fb->panel->caps = panels[i].caps & CLCD_CAP_RGB;
> - if (r0 == panels[i].b0 && b0 == panels[i].r0)
> - fb->panel->caps = panels[i].caps & CLCD_CAP_BGR;
> + fb->panel->caps = panels[i].caps;
> }
>
> return fb->panel->caps ? 0 : -EINVAL;
>
Thanks, queued for 3.17 fbdev fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-09-12 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 14:15 [PATCH] video: ARM CLCD: Fix color model capabilities for DT platforms Pawel Moll
2014-09-12 8:50 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412B3EF.9090604@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).