From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: balbi@ti.com
Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/5] OMAPFB: remove wrong __exit and __exit_p()
Date: Thu, 16 Oct 2014 13:23:00 +0000 [thread overview]
Message-ID: <543FC6B4.4060304@ti.com> (raw)
In-Reply-To: <20141016131939.GB3480@saruman>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
On 16/10/14 16:19, Felipe Balbi wrote:
> On Thu, Oct 16, 2014 at 12:39:44PM +0300, Tomi Valkeinen wrote:
>> omapfb device can be unbound, so using __exit_p() for the driver's
>> remove callback is wrong.
>>
>> Remove __exit_p() and __exit from the driver's remove.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> and why was my version dropped ?
>
> http://marc.info/?l=linux-fbdev&m=141331137230988&w=2
Oh, sorry, for no reason. I started from scratch as there seemed to be
enough issues there, and didn't remember you had the exact same patch.
I'll use yours instead of my version.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-16 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 9:39 [PATCH 1/5] OMAPDSS: set suppress_bind_attrs Tomi Valkeinen
2014-10-16 9:39 ` [PATCH 2/5] OMAPFB: remove wrong __exit and __exit_p() Tomi Valkeinen
2014-10-16 13:19 ` Felipe Balbi
2014-10-16 13:23 ` Tomi Valkeinen [this message]
2014-10-16 9:39 ` [PATCH 3/5] OMAPDSS: apply: wait pending updates on manager disable Tomi Valkeinen
2014-10-16 9:39 ` [PATCH 4/5] OMAPFB: fix overlay disable when freeing resources Tomi Valkeinen
2014-10-16 9:39 ` [PATCH 5/5] OMAPFB: fix releasing overlays Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543FC6B4.4060304@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=balbi@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).