From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-fbdev@vger.kernel.org, linux-pwm@vger.kernel.org,
Jingoo Han <jg1.han@samsung.com>, Bryan Wu <cooloney@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Dmitry Eremin-Solenikov <dmitry_eremin@mentor.com>
Subject: Re: [PATCH 2/2] backlight: pwm: clean up pwm requested using legacy API
Date: Thu, 06 Nov 2014 22:10:25 +0000 [thread overview]
Message-ID: <545BF1D1.30304@mentor.com> (raw)
In-Reply-To: <20141011142156.GC11456@kroah.com>
Hello Greg, Thierry,
On 11.10.2014 17:21, Greg KH wrote:
> On Sat, Oct 11, 2014 at 04:46:26PM +0300, Vladimir Zapolskiy wrote:
>> If PWM device is requested by means of legacy API pwm_request(), its
>> resources are not freed on module unbind, which may cause an oops on
>> access, e.g. by reading /sys/kernel/debug/pwm.
>>
>> Reported-by: Dmitry Eremin-Solenikov <dmitry_eremin@mentor.com>
>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
>> ---
>> drivers/video/backlight/pwm_bl.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
>
> </formletter>
> --
could you please review the change? I believe it would be nice to have
oops fix in v3.18.
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2014-11-06 22:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 13:46 [PATCH 0/2] backlight: pwm: fix oops on accessing removed legacy pwm device Vladimir Zapolskiy
2014-10-11 13:46 ` [PATCH 1/2] backlight: pwm: don't call legacy pwm request for device defined in dt Vladimir Zapolskiy
2014-10-11 14:21 ` Greg KH
2014-11-07 13:48 ` Thierry Reding
2014-11-07 14:19 ` Vladimir Zapolskiy
2014-11-07 14:57 ` Vladimir Zapolskiy
2014-12-01 14:47 ` Vladimir Zapolskiy
2015-01-21 13:18 ` Vladimir Zapolskiy
2015-06-12 11:31 ` Thierry Reding
2015-06-12 12:57 ` Vladimir Zapolskiy
2015-06-12 13:19 ` Thierry Reding
2014-10-11 13:46 ` [PATCH 2/2] backlight: pwm: clean up pwm requested using legacy API Vladimir Zapolskiy
2014-10-11 14:21 ` Greg KH
2014-11-06 22:10 ` Vladimir Zapolskiy [this message]
2014-11-06 22:54 ` Greg KH
2014-11-07 11:50 ` Lee Jones
2014-11-07 13:47 ` Thierry Reding
2014-11-10 10:01 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545BF1D1.30304@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=cooloney@gmail.com \
--cc=dmitry_eremin@mentor.com \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).