linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: alsa-devel@alsa-project.org, linux-fbdev@vger.kernel.org,
	linux-omap@vger.kernel.org
Cc: peter.ujfalusi@ti.com, broonie@kernel.org,
	liam.r.girdwood@linux.intel.com, tomi.valkeinen@ti.com
Subject: Re: [PATCH v7 06/20] OMAPDSS: omapdss.h: Remove audio_state member of struct omap_dss_device
Date: Wed, 12 Nov 2014 14:34:33 +0000	[thread overview]
Message-ID: <54636FF9.5000303@ti.com> (raw)
In-Reply-To: <2c129e22e96eba98ec1d825d01c25571272da13b.1415786458.git.jsarha@ti.com>

Damn, this patch should have gone to second last for it not not to break 
bisect. I'll squash it into "OMAPDSS: Remove all references to obsolete 
HDMI audio callbacks" an mail v7.1 patch-set shortly.

Best regards,
Jyri

On 11/12/2014 12:49 PM, Jyri Sarha wrote:
> The audio_state member is not used.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
>   include/video/omapdss.h |    9 ---------
>   1 file changed, 9 deletions(-)
>
> diff --git a/include/video/omapdss.h b/include/video/omapdss.h
> index 069dfca..9f2699f 100644
> --- a/include/video/omapdss.h
> +++ b/include/video/omapdss.h
> @@ -166,13 +166,6 @@ enum omap_dss_display_state {
>   	OMAP_DSS_DISPLAY_ACTIVE,
>   };
>
> -enum omap_dss_audio_state {
> -	OMAP_DSS_AUDIO_DISABLED = 0,
> -	OMAP_DSS_AUDIO_ENABLED,
> -	OMAP_DSS_AUDIO_CONFIGURED,
> -	OMAP_DSS_AUDIO_PLAYING,
> -};
> -
>   struct omap_dss_audio {
>   	struct snd_aes_iec958 *iec;
>   	struct snd_cea_861_aud_if *cea;
> @@ -783,8 +776,6 @@ struct omap_dss_device {
>
>   	enum omap_dss_display_state state;
>
> -	enum omap_dss_audio_state audio_state;
> -
>   	/* OMAP DSS output specific fields */
>
>   	struct list_head list;
>


  reply	other threads:[~2014-11-12 14:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 10:49 [PATCH v7 00/20] Rework OMAP4+ HDMI audio support Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 01/20] OMAPDSS: hdmi_wp: Protect reserved bits in hdmi_wp_audio_config_format() Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 02/20] OMAPDSS: hdmi5_core: Initialize mandatory sample_order parameter Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 03/20] OMAPDSS: hdmi.h: Add HDMI_AUDIO_LAYOUT_6CH enum value Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 04/20] OMAPDSS: hdmi: Remove most of OMAP[45]_DSS_HDMI_AUDIO ifdefs Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 05/20] OMAPDSS: hdmi4_core: Remove unused hdmi4_audio_get_dma_port() Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 06/20] OMAPDSS: omapdss.h: Remove audio_state member of struct omap_dss_device Jyri Sarha
2014-11-12 14:34   ` Jyri Sarha [this message]
2014-11-12 10:49 ` [PATCH v7 07/20] OMAPDSS: hdmi_wp: Add function for getting audio dma address Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 08/20] OMAPDSS: hdmi: Make hdmi structure public Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 09/20] OMAPDSS: hdmi: Add pdev pointer for audio_pdev in HDMI DRV data Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 10/20] ASoC: omap-hdmi-audio: Add platform device for OMAP HDMI audio support Jyri Sarha
2014-11-12 12:03   ` Peter Ujfalusi
2014-11-12 10:49 ` [PATCH v7 11/20] OMAPDSS: Kconfig: Remove HDMI audio booleans from Kconfig Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 12/20] OMAPDSS: hdmi: Make hdmi_mode_has_audio() more user friedly Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 13/20] OMAPDSS: hdmi.h: Add members to hdmi drvdata for audio implementation Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 14/20] OMAPDSS: hdmi4: Remove callbacks for the old ASoC DAI driver Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 15/20] OMAPDSS: hdmi4: Register ASoC platform device for omap hdmi audio Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 16/20] OMAPDSS: hdmi5: Remove callbacks for the old ASoC DAI driver Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 17/20] OMAPDSS: hdmi5: Register ASoC platform device for omap hdmi audio Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 18/20] ASoC: omap: Remove obsolete HDMI audio code and Kconfig options Jyri Sarha
2014-11-12 12:04   ` Peter Ujfalusi
2014-11-12 10:49 ` [PATCH v7 19/20] OMAPDSS: Remove all references to obsolete HDMI audio callbacks Jyri Sarha
2014-11-12 10:49 ` [PATCH v7 20/20] OMAPDSS: hdmi5: Change hdmi_wp idlemode to to no_idle for audio playback Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54636FF9.5000303@ti.com \
    --to=jsarha@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).