From: Hans de Goede <hdegoede@redhat.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/4] simplefb: Change simplefb_init from module_init to fs_initcall
Date: Thu, 13 Nov 2014 14:47:31 +0000 [thread overview]
Message-ID: <5464C483.4040507@redhat.com> (raw)
In-Reply-To: <5464C10A.30709@ti.com>
Hi,
On 11/13/2014 03:32 PM, Tomi Valkeinen wrote:
> On 13/11/14 15:34, Hans de Goede wrote:
>> One of the reasons for having the simplefb nodes in /chosen, and doing
>> explicit enumeration of the nodes there, is too allow enumerating them sooner,
>> so that we get a console earlier on.
>>
>> Doing this earlier then fs_initcall is not useful, since the fb only turns into
>> a console when fbcon intializes, which is a fs_initcall too.
>
> The above text is slightly confusing, as fbcon initializes at
> module_init time. You only change it in the next patch. I can move the
> fbcon change to be the first patch when applying, if there are no more
> versions sent.
True, feel free to swap them when applying.
Regards,
Hans
next prev parent reply other threads:[~2014-11-13 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 13:34 [PATCH v3 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Hans de Goede
2014-11-13 13:34 ` [PATCH v3 2/4] simplefb: Add support for enumerating simplefb dt nodes in /chosen Hans de Goede
2014-11-13 13:34 ` [PATCH v3 3/4] simplefb: Change simplefb_init from module_init to fs_initcall Hans de Goede
2014-11-13 14:32 ` Tomi Valkeinen
2014-11-13 14:47 ` Hans de Goede [this message]
2014-11-13 13:34 ` [PATCH v3 4/4] fbcon: Change fbcon_init " Hans de Goede
2014-11-13 14:34 ` Tomi Valkeinen
2014-11-13 14:28 ` [PATCH v3 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Tomi Valkeinen
2014-11-13 14:46 ` [linux-sunxi] Re: [PATCH v3 1/4] dt-bindings: simplefb: Specify node location and handoff relate Hans de Goede
2014-11-13 15:52 ` Tomi Valkeinen
2014-11-13 16:07 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5464C483.4040507@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).