From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 0/5] simplefb: add clock handling code
Date: Thu, 13 Nov 2014 15:20:58 +0000 [thread overview]
Message-ID: <5464CC5A.7010508@ti.com> (raw)
In-Reply-To: <1415808952-23549-1-git-send-email-hdegoede@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1865 bytes --]
On 12/11/14 18:15, Hans de Goede wrote:
> Hi Tomi,
>
> Here is v5 of my simplefb patch-set, this time with an Ack from
> Grant Likely for the dt-bindings bits, which should end all controversy
> surrounding that patch.
>
> For changes since the original postings please see the per patch changelogs
> in the patch commit messages.
>
> Please merge this into your tree for 3.19.
I applied this and the "dt-bindings: simplefb: Specify node location and
handoff related properties" v3 series to my test branch, compiled for
x64 and:
drivers/video/fbdev/simplefb.c: In function ‘simplefb_clocks_init’:
drivers/video/fbdev/simplefb.c:204:2: error: implicit declaration of
function ‘of_clk_get_parent_count’ [-Werror=implicit-function-declaration]
par->clk_count = of_clk_get_parent_count(np);
^
In file included from include/linux/i2c.h:33:0,
from include/uapi/linux/fb.h:5,
from include/linux/fb.h:5,
from drivers/video/fbdev/simplefb.c:24:
drivers/video/fbdev/simplefb.c: In function ‘simplefb_init’:
drivers/video/fbdev/simplefb.c:399:25: error: ‘of_chosen’ undeclared
(first use in this function)
for_each_child_of_node(of_chosen, np) {
^
include/linux/of.h:736:33: note: in definition of macro
‘for_each_child_of_node’
for (child = of_get_next_child(parent, NULL); child != NULL; \
^
drivers/video/fbdev/simplefb.c:399:25: note: each undeclared identifier
is reported only once for each function it appears in
for_each_child_of_node(of_chosen, np) {
^
include/linux/of.h:736:33: note: in definition of macro
‘for_each_child_of_node’
for (child = of_get_next_child(parent, NULL); child != NULL; \
^
We need "depends on OF"?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-13 15:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 16:15 [PATCH v5 0/5] simplefb: add clock handling code Hans de Goede
2014-11-12 16:15 ` [PATCH v5 1/5] simplefb: Add simplefb MAINTAINERS entry Hans de Goede
2014-11-12 16:15 ` [PATCH v5 2/5] dt-bindings: Add a clocks property to the simple-framebuffer binding Hans de Goede
2014-11-12 16:15 ` [PATCH v5 3/5] simplefb: formalize pseudo palette handling Hans de Goede
2014-11-12 16:15 ` [PATCH v5 4/5] simplefb: add goto error path to probe Hans de Goede
2014-11-12 16:15 ` [PATCH v5 5/5] simplefb: add clock handling code Hans de Goede
2014-11-13 7:38 ` [PATCH v5 0/5] " Grant Likely
2014-11-13 16:05 ` Grant Likely
2014-11-13 16:22 ` Tomi Valkeinen
2014-11-13 15:20 ` Tomi Valkeinen [this message]
2014-11-13 18:00 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5464CC5A.7010508@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).