From: Jyri Sarha <jsarha@ti.com>
To: Mark Brown <broonie@kernel.org>, Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: alsa-devel@alsa-project.org, linux-fbdev@vger.kernel.org,
linux-omap@vger.kernel.org, peter.ujfalusi@ti.com,
liam.r.girdwood@linux.intel.com
Subject: Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support
Date: Fri, 21 Nov 2014 12:10:11 +0000 [thread overview]
Message-ID: <546F2BA3.9050203@ti.com> (raw)
In-Reply-To: <20141121112317.GQ3815@sirena.org.uk>
On 11/21/2014 01:23 PM, Mark Brown wrote:
> On Thu, Nov 20, 2014 at 12:59:44PM +0200, Tomi Valkeinen wrote:
>
>> The series looks good to me, and works for me.
>
>> Do you have any comments for the sound/ parts? If not, I can merge this
>> series via fbdev tree, and for that I'd like your ack on the sound/ patches.
>
> I've not reviewed it yet and I'm still seeing some fairly basic
> discussion between Jiri and Jean-Francois about approaches to
> integrating HDMI which seem to have ground to a halt (I've not been
> reading them in any detail). The fact that we're getting no sharing at
> all between all the different HDMI devices people are supporting and
> very limited dialogue between them is really setting off alarm bells.
>
OMAP HDMI audio is fundamentally different to the case on Armada or on
BBB. In omap the whole HDMI IP is integrated to the SoC and there really
is no codec in the ASoC sense. The the cpu-dai transmits the audio
directly to hdmi wire and there is no i2s bus involved. So this case
should not be mixed with the patches Jean-Francois working on. The code
is also orthogonal in that sense that the latest omap-hdmi-audio uses
the generic dymmy codec.
The issue about generic HDMI codec, that Jean-Francois (and soon me) is
trying to solve - applies to the cases where a generic cpu-dai is
connected to an external HDMI encoder with i2s (or s/pdif, unfortunately
do not have such HW). In these cases the structure of the ASoC setup
resembles closely the usual pattern of ASoC cards. The main difference
is just that the "codec" IP also handling the video and there are no
mixers, etc.
I am currently trying to find the common denominator between tda998x and
SiI9022 HDMI encoder chips to come up with a generic solution for the
external HDMI encoder case. However, this work is completely separate to
the omap-hdmi-audio and its review should not be delayed because of the
hdmi codec work.
Best regards,
Jyri
> As far as I can tell in order to figure out what to do with all this
> HDMI stuff I'm going to need to go to square one, get an overview of the
> hardware that's out there for myself and try to work out what to do with
> it.
>
> With this specific series I also need to figure out what all the video
> side is about (like I said earlier a lot of the patches look like
> they're supposed to be simple fixes for the video code not terribly
> closely tied to the rest of the series but none of them are getting
> applied) and what the end goal is beyond mechanically moving code.
>
next prev parent reply other threads:[~2014-11-21 12:10 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 14:40 [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support Jyri Sarha
2014-11-12 14:40 ` [PATCH v7.1 01/19] OMAPDSS: hdmi_wp: Protect reserved bits in hdmi_wp_audio_config_format() Jyri Sarha
2014-11-12 14:40 ` [PATCH v7.1 02/19] OMAPDSS: hdmi5_core: Initialize mandatory sample_order parameter Jyri Sarha
2014-11-12 14:40 ` [PATCH v7.1 03/19] OMAPDSS: hdmi.h: Add HDMI_AUDIO_LAYOUT_6CH enum value Jyri Sarha
2014-11-12 14:40 ` [PATCH v7.1 04/19] OMAPDSS: hdmi: Remove most of OMAP[45]_DSS_HDMI_AUDIO ifdefs Jyri Sarha
2014-11-12 14:40 ` [PATCH v7.1 05/19] OMAPDSS: hdmi4_core: Remove unused hdmi4_audio_get_dma_port() Jyri Sarha
2014-11-12 14:40 ` [PATCH v7.1 06/19] OMAPDSS: hdmi_wp: Add function for getting audio dma address Jyri Sarha
2014-11-12 14:40 ` [PATCH v7.1 07/19] OMAPDSS: hdmi: Make hdmi structure public Jyri Sarha
2014-11-12 14:40 ` [PATCH v7.1 08/19] OMAPDSS: hdmi: Add pdev pointer for audio_pdev in HDMI DRV data Jyri Sarha
2014-11-12 14:41 ` [PATCH v7.1 09/19] ASoC: omap-hdmi-audio: Add platform device for OMAP HDMI audio support Jyri Sarha
2014-11-29 11:32 ` Mark Brown
2014-12-01 7:15 ` Jyri Sarha
2014-12-01 19:21 ` Mark Brown
2014-11-12 14:41 ` [PATCH v7.1 10/19] OMAPDSS: Kconfig: Remove HDMI audio booleans from Kconfig Jyri Sarha
2014-11-12 14:41 ` [PATCH v7.1 11/19] OMAPDSS: hdmi: Make hdmi_mode_has_audio() more user friedly Jyri Sarha
2014-11-14 14:37 ` Vladimir Zapolskiy
2014-11-14 15:05 ` Jyri Sarha
2014-11-17 15:12 ` Vladimir Zapolskiy
2014-11-15 15:52 ` Vladimir Zapolskiy
2014-11-12 14:41 ` [PATCH v7.1 12/19] OMAPDSS: hdmi.h: Add members to hdmi drvdata for audio implementation Jyri Sarha
2014-11-12 14:41 ` [PATCH v7.1 13/19] OMAPDSS: hdmi4: Remove callbacks for the old ASoC DAI driver Jyri Sarha
2014-11-12 14:41 ` [PATCH v7.1 14/19] OMAPDSS: hdmi4: Register ASoC platform device for omap hdmi audio Jyri Sarha
2014-11-12 14:41 ` [PATCH v7.1 15/19] OMAPDSS: hdmi5: Remove callbacks for the old ASoC DAI driver Jyri Sarha
2014-11-12 14:41 ` [PATCH v7.1 16/19] OMAPDSS: hdmi5: Register ASoC platform device for omap hdmi audio Jyri Sarha
2014-11-12 14:41 ` [PATCH v7.1 17/19] ASoC: omap: Remove obsolete HDMI audio code and Kconfig options Jyri Sarha
2014-11-12 14:41 ` [PATCH v7.1 18/19] OMAPDSS: Remove all references to obsolete HDMI audio callbacks Jyri Sarha
2014-11-12 14:41 ` [PATCH v7.1 19/19] OMAPDSS: hdmi5: Change hdmi_wp idlemode to to no_idle for audio playback Jyri Sarha
2014-11-12 22:23 ` [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support Mark Brown
2014-11-13 8:05 ` Tomi Valkeinen
2014-11-13 9:17 ` [alsa-devel] " Jean-Francois Moine
2014-11-13 10:00 ` Tomi Valkeinen
2014-11-13 14:54 ` Jyri Sarha
2014-11-13 14:57 ` Jean-Francois Moine
2014-11-13 15:44 ` Tomi Valkeinen
2014-11-14 10:59 ` Jean-Francois Moine
2014-11-20 10:59 ` Tomi Valkeinen
2014-11-21 11:23 ` Mark Brown
2014-11-21 12:10 ` Jyri Sarha [this message]
2014-11-21 16:38 ` Mark Brown
2014-11-24 8:48 ` Tomi Valkeinen
2014-11-24 14:55 ` Jyri Sarha
2014-11-21 12:35 ` Jyri Sarha
2014-11-21 16:14 ` Mark Brown
2014-11-24 8:18 ` Tomi Valkeinen
2014-11-24 17:39 ` Mark Brown
2014-11-25 9:26 ` Tomi Valkeinen
2014-11-25 18:10 ` Mark Brown
2014-11-26 11:02 ` Tomi Valkeinen
2014-11-29 11:59 ` Mark Brown
2014-12-01 9:07 ` Tomi Valkeinen
2014-12-01 19:31 ` Mark Brown
2014-12-02 8:52 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546F2BA3.9050203@ti.com \
--to=jsarha@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).