From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Qiang Chen <qiang2.chen@sonymobile.com>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Jingoo Han <jg1.han@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Qiang Chen <qcwj.lk@gmail.com>
Subject: Re: [PATCH] video: ocfb: Fix data type warning
Date: Tue, 13 Jan 2015 10:49:17 +0000 [thread overview]
Message-ID: <54B4F82D.6040905@ti.com> (raw)
In-Reply-To: <1417767510-31462-1-git-send-email-qiang2.chen@sonymobile.com>
[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]
On 05/12/14 10:18, Qiang Chen wrote:
> When allocate framebuffer memory using dma_alloc_coherent(),
> we'd better use dma_addr_t instead of phys_addr_t. Because the
> address we got in fact is DMA or bus address for the platform.
>
> This patch also fixes below build warning:
> drivers/video/fbdev/ocfb.c:335:2:
> warning: passing argument 3 of ‘dma_alloc_attrs’
> from incompatible pointer type [enabled by default]
>
> Signed-off-by: Qiang Chen <qiang2.chen@sonymobile.com>
> ---
> drivers/video/fbdev/ocfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/ocfb.c b/drivers/video/fbdev/ocfb.c
> index 7f9dc9b..de98196 100644
> --- a/drivers/video/fbdev/ocfb.c
> +++ b/drivers/video/fbdev/ocfb.c
> @@ -61,7 +61,7 @@ struct ocfb_dev {
> /* flag indicating whether the regs are little endian accessed */
> int little_endian;
> /* Physical and virtual addresses of framebuffer */
> - phys_addr_t fb_phys;
> + dma_addr_t fb_phys;
> void __iomem *fb_virt;
> u32 pseudo_palette[PALETTE_SIZE];
> };
>
Thanks, queued for 3.20.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-01-13 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 8:18 [PATCH] video: ocfb: Fix data type warning Qiang Chen
2014-12-07 6:08 ` Stefan Kristiansson
2015-01-13 10:49 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B4F82D.6040905@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=daniel.vetter@ffwll.ch \
--cc=jg1.han@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=qcwj.lk@gmail.com \
--cc=qiang2.chen@sonymobile.com \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).