* [PATCH] fbdev: omap2: Fix typo in tvc_probe_pdata
@ 2015-01-05 13:09 Rasmus Villemoes
2015-01-13 11:26 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Rasmus Villemoes @ 2015-01-05 13:09 UTC (permalink / raw)
To: Tomi Valkeinen, Jean-Christophe Plagniol-Villard
Cc: Rasmus Villemoes, linux-omap, linux-fbdev, linux-kernel
Assigning ddata->invert_polarity to itself is not very useful; the
context suggests that the right-hand side should have been
pdata->invert_polarity.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c b/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c
index 9a2b5ce58545..8511c648a15c 100644
--- a/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c
+++ b/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c
@@ -208,7 +208,7 @@ static int tvc_probe_pdata(struct platform_device *pdev)
ddata->in = in;
ddata->connector_type = pdata->connector_type;
- ddata->invert_polarity = ddata->invert_polarity;
+ ddata->invert_polarity = pdata->invert_polarity;
dssdev = &ddata->dssdev;
dssdev->name = pdata->name;
--
2.1.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: omap2: Fix typo in tvc_probe_pdata
2015-01-05 13:09 [PATCH] fbdev: omap2: Fix typo in tvc_probe_pdata Rasmus Villemoes
@ 2015-01-13 11:26 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2015-01-13 11:26 UTC (permalink / raw)
To: Rasmus Villemoes, Jean-Christophe Plagniol-Villard
Cc: linux-omap, linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
On 05/01/15 15:09, Rasmus Villemoes wrote:
> Assigning ddata->invert_polarity to itself is not very useful; the
> context suggests that the right-hand side should have been
> pdata->invert_polarity.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c b/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c
> index 9a2b5ce58545..8511c648a15c 100644
> --- a/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c
> +++ b/drivers/video/fbdev/omap2/displays-new/connector-analog-tv.c
> @@ -208,7 +208,7 @@ static int tvc_probe_pdata(struct platform_device *pdev)
> ddata->in = in;
>
> ddata->connector_type = pdata->connector_type;
> - ddata->invert_polarity = ddata->invert_polarity;
> + ddata->invert_polarity = pdata->invert_polarity;
>
> dssdev = &ddata->dssdev;
> dssdev->name = pdata->name;
Good catch, thanks! Queueing for 3.20 (as no one is using that flag in
3.19).
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-13 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-05 13:09 [PATCH] fbdev: omap2: Fix typo in tvc_probe_pdata Rasmus Villemoes
2015-01-13 11:26 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).