From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Scot Doyle <lkml14@scotdoyle.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] fbcon: Remove unused vblank cursor code
Date: Mon, 26 Jan 2015 12:11:43 +0000 [thread overview]
Message-ID: <54C62EFF.1010202@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1501232247340.2377@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
On 24/01/15 00:55, Scot Doyle wrote:
> commit 1fa0b29f3a43 ("fbdev: Kill Atari vblank cursor blinking")
>
> rendered vbl_cursor_cnt and therefore CURSOR_DRAW_DELAY unused in fbcon.c,
> so remove them.
>
> Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> ---
> drivers/video/console/fbcon.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index ea43724..b972106 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -146,9 +146,6 @@ static const struct consw fb_con;
>
> static int fbcon_set_origin(struct vc_data *);
>
> -#define CURSOR_DRAW_DELAY (1)
> -
> -static int vbl_cursor_cnt;
> static int fbcon_cursor_noblink;
>
> #define divides(a, b) ((!(a) || (b)%(a)) ? 0 : 1)
> @@ -1329,7 +1326,6 @@ static void fbcon_cursor(struct vc_data *vc, int mode)
>
> ops->cursor(vc, info, mode, y, get_color(vc, info, c, 1),
> get_color(vc, info, c, 0));
> - vbl_cursor_cnt = CURSOR_DRAW_DELAY;
> }
>
> static int scrollback_phys_max = 0;
>
Thanks, queued for 3.20.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-01-26 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 22:55 [RFC PATCH] fbcon: Remove unused vblank cursor code Scot Doyle
2015-01-26 12:11 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C62EFF.1010202@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml14@scotdoyle.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).