From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arun Ramamurthy Date: Wed, 04 Mar 2015 00:31:44 +0000 Subject: Re: [PATCH] video: ARM CLCD: Added support for FBIO_WAITFORVSYNC Message-Id: <54F65270.20704@broadcom.com> List-Id: References: <1424898082-1522-1-git-send-email-arun.ramamurthy@broadcom.com> <1424898082-1522-3-git-send-email-arun.ramamurthy@broadcom.com> <1425312029.3092.1.camel@arm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Rob Herring , Pawel Moll Cc: Rob Herring , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , Dmitry Torokhov , Anatol Pomazau , Jonathan Richardson , Scott Branden , Ray Jui , "bcm-kernel-feedback-list@broadcom.com" On 15-03-02 03:27 PM, Rob Herring wrote: > On Mon, Mar 2, 2015 at 10:00 AM, Pawel Moll wrote: >> On Wed, 2015-02-25 at 21:01 +0000, Arun Ramamurthy wrote: >>> Added ioctl and interrupt handler functions to support FBIO_WAITFORVSYNC >>> Also corrected documentation to make interrupts and interrupt-names >>> optional as they are not required properties. >> >> You may not be aware of this fact, but its the "documentation" what >> defines what properties are required... > > Except when docs are wrong. Then dts files win. > >>> Reviewed-by: Ray Jui >>> Reviewed-by: Scott Branden >>> Signed-off-by: Arun Ramamurthy 0 >>> --- >>> .../devicetree/bindings/video/arm,pl11x.txt | 11 +-- >>> drivers/video/fbdev/amba-clcd.c | 82 ++++++++++++++++++++++ >>> include/linux/amba/clcd.h | 4 ++ >>> 3 files changed, 89 insertions(+), 8 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/video/arm,pl11x.txt b/Documentation/devicetree/bindings/video/arm,pl11x.txt >>> index 2262cdb..7d19024 100644 >>> --- a/Documentation/devicetree/bindings/video/arm,pl11x.txt >>> +++ b/Documentation/devicetree/bindings/video/arm,pl11x.txt >>> @@ -10,14 +10,6 @@ Required properties: >>> >>> - reg: base address and size of the control registers block >>> >>> -- interrupt-names: either the single entry "combined" representing a >>> - combined interrupt output (CLCDINTR), or the four entries >>> - "mbe", "vcomp", "lnbu", "fuf" representing the individual >>> - CLCDMBEINTR, CLCDVCOMPINTR, CLCDLNBUINTR, CLCDFUFINTR interrupts >>> - >>> -- interrupts: contains an interrupt specifier for each entry in >>> - interrupt-names >>> - >>> - clock-names: should contain "clcdclk" and "apb_pclk" >>> >>> - clocks: contains phandle and clock specifier pairs for the entries >> >> So no, you can't do that. > > You can't do the other way around (making optional ones required), but > I think this is okay if the h/w interrupt lines are not physically > connected. However, if it is simply because the driver doesn't use > them, then I agree this should not be changed. > Agreed, I will undo this change in V2 > Rob >