* Re: [PATCH] sm750fb: Fix C99 Comments and if else braces
2015-03-19 17:51 [PATCH] sm750fb: Fix C99 Comments and if else braces Amitoj Kaur Chawla
@ 2015-03-19 17:42 ` Giedrius Statkevičius
2015-03-19 18:06 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Giedrius Statkevičius @ 2015-03-19 17:42 UTC (permalink / raw)
To: Amitoj Kaur Chawla, sudipm.mukherjee, teddy.wang, gregkh,
linux-fbdev, devel, linux-kernel
Hi Amitoj Kaur Chawla,
On 2015.03.19 19:39, Amitoj Kaur Chawla wrote:
> The edits have been made to remove C99 Comments and properly indent
> the if-else statements in the file while taking care of the braces according to
> Linux coding style.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 25 +++++++++++--------------
> 1 file changed, 11 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 33add64..33fa456 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -17,25 +17,22 @@ logical_chip_type_t getChipType(void)
> char physicalRev;
> logical_chip_type_t chip;
>
> - physicalID = devId750;//either 0x718 or 0x750
> + physicalID = devId750;/* either 0x718 or 0x750 */
Add a space here after ;?
> physicalRev = revId750;
>
> - if (physicalID = 0x718)
> - {
> - chip = SM718;
> - }
> - else if (physicalID = 0x750)
> - {
> - chip = SM750;
> + if (physicalID = 0x718) {
> + chip = SM718;
> + }
> + else if (physicalID = 0x750) {
> + chip = SM750;
> /* SM750 and SM750LE are different in their revision ID only. */
> - if (physicalRev = SM750LE_REVISION_ID){
> + if (physicalRev = SM750LE_REVISION_ID) {
> chip = SM750LE;
> }
> - }
> - else
> - {
> - chip = SM_UNKNOWN;
> - }
> + }
> + else {
> + chip = SM_UNKNOWN;
> + }
>
> return chip;
> }
>
--
Thanks,
Giedrius
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] sm750fb: Fix C99 Comments and if else braces
2015-03-19 17:42 ` Giedrius Statkevičius
@ 2015-03-19 17:51 Amitoj Kaur Chawla
2015-03-19 17:42 ` Giedrius Statkevičius
2015-03-19 18:06 ` Joe Perches
-1 siblings, 2 replies; 3+ messages in thread
From: Amitoj Kaur Chawla @ 2015-03-19 17:51 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel
The edits have been made to remove C99 Comments and properly indent
the if-else statements in the file while taking care of the braces according to
Linux coding style.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 25 +++++++++++--------------
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 33add64..33fa456 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -17,25 +17,22 @@ logical_chip_type_t getChipType(void)
char physicalRev;
logical_chip_type_t chip;
- physicalID = devId750;//either 0x718 or 0x750
+ physicalID = devId750;/* either 0x718 or 0x750 */
physicalRev = revId750;
- if (physicalID = 0x718)
- {
- chip = SM718;
- }
- else if (physicalID = 0x750)
- {
- chip = SM750;
+ if (physicalID = 0x718) {
+ chip = SM718;
+ }
+ else if (physicalID = 0x750) {
+ chip = SM750;
/* SM750 and SM750LE are different in their revision ID only. */
- if (physicalRev = SM750LE_REVISION_ID){
+ if (physicalRev = SM750LE_REVISION_ID) {
chip = SM750LE;
}
- }
- else
- {
- chip = SM_UNKNOWN;
- }
+ }
+ else {
+ chip = SM_UNKNOWN;
+ }
return chip;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sm750fb: Fix C99 Comments and if else braces
2015-03-19 17:51 [PATCH] sm750fb: Fix C99 Comments and if else braces Amitoj Kaur Chawla
2015-03-19 17:42 ` Giedrius Statkevičius
@ 2015-03-19 18:06 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2015-03-19 18:06 UTC (permalink / raw)
To: Amitoj Kaur Chawla
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel
On Thu, 2015-03-19 at 23:09 +0530, Amitoj Kaur Chawla wrote:
> The edits have been made to remove C99 Comments and properly indent
> the if-else statements in the file while taking care of the braces according to
> Linux coding style.
Please scan your proposed patches with checkpatch
and fix possible style defects before sending them.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-19 18:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-19 17:51 [PATCH] sm750fb: Fix C99 Comments and if else braces Amitoj Kaur Chawla
2015-03-19 17:42 ` Giedrius Statkevičius
2015-03-19 18:06 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).