* Re: [PATCH] sm750fb: Fix Comment and if else braces
2015-03-19 18:17 [PATCH] sm750fb: Fix Comment and if else braces Amitoj Kaur Chawla
@ 2015-03-19 18:13 ` Giedrius Statkevičius
2015-03-20 13:04 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Giedrius Statkevičius @ 2015-03-19 18:13 UTC (permalink / raw)
To: Amitoj Kaur Chawla, sudipm.mukherjee, teddy.wang, gregkh,
linux-fbdev, devel, linux-kernel
Hi Amitoj Kaur Chawla,
On 2015.03.19 20:05, Amitoj Kaur Chawla wrote:
> The edits have been made to add a space before the comment and the errors in
> braces in the if-else statements.
> Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed
> the C99 comments and errors in if-else indentation and braces.
The previous patch isn't in the git repo yet so it doesn't have a commit
id thus this one is wrong. You should've just made a v2 and made that
change. I recommend you to look over this:
http://kernelnewbies.org/FirstKernelPatch Just remove the HEAD commit in
your local git repo, add that space and then when using `git
format-patch` use the "--subject-prefix" option to add that it's a
second version. Then after "---" you can say what was changed in the
second version. For example (I'm sure you can think of a better one!):
Signed-off-by: ...
---
v2: added a space after a statement in a line where a coding style error
was fixed.
drivers/...
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 33fa456..bdf6a73 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -17,20 +17,17 @@ logical_chip_type_t getChipType(void)
> char physicalRev;
> logical_chip_type_t chip;
>
> - physicalID = devId750;/* either 0x718 or 0x750 */
> + physicalID = devId750; /* either 0x718 or 0x750 */
> physicalRev = revId750;
>
> if (physicalID = 0x718) {
> chip = SM718;
> - }
> - else if (physicalID = 0x750) {
> + } else if (physicalID = 0x750) {
> chip = SM750;
> /* SM750 and SM750LE are different in their revision ID only. */
> - if (physicalRev = SM750LE_REVISION_ID) {
> + if (physicalRev = SM750LE_REVISION_ID)
> chip = SM750LE;
> - }
> - }
> - else {
> + } else {
> chip = SM_UNKNOWN;
> }
>
>
--
Thanks,
Giedrius
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] sm750fb: Fix Comment and if else braces
2015-03-19 18:13 ` Giedrius Statkevičius
@ 2015-03-19 18:17 Amitoj Kaur Chawla
2015-03-19 18:13 ` Giedrius Statkevičius
0 siblings, 1 reply; 3+ messages in thread
From: Amitoj Kaur Chawla @ 2015-03-19 18:17 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel,
linux-kernel
The edits have been made to add a space before the comment and the errors in
braces in the if-else statements.
Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed
the C99 comments and errors in if-else indentation and braces.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 33fa456..bdf6a73 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -17,20 +17,17 @@ logical_chip_type_t getChipType(void)
char physicalRev;
logical_chip_type_t chip;
- physicalID = devId750;/* either 0x718 or 0x750 */
+ physicalID = devId750; /* either 0x718 or 0x750 */
physicalRev = revId750;
if (physicalID = 0x718) {
chip = SM718;
- }
- else if (physicalID = 0x750) {
+ } else if (physicalID = 0x750) {
chip = SM750;
/* SM750 and SM750LE are different in their revision ID only. */
- if (physicalRev = SM750LE_REVISION_ID) {
+ if (physicalRev = SM750LE_REVISION_ID)
chip = SM750LE;
- }
- }
- else {
+ } else {
chip = SM_UNKNOWN;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sm750fb: Fix Comment and if else braces
2015-03-19 18:13 ` Giedrius Statkevičius
@ 2015-03-20 13:04 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-03-20 13:04 UTC (permalink / raw)
To: Giedrius Statkevičius
Cc: Amitoj Kaur Chawla, sudipm.mukherjee, teddy.wang, linux-fbdev,
devel, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1339 bytes --]
On Thu, Mar 19, 2015 at 08:13:20PM +0200, Giedrius Statkevičius wrote:
> Hi Amitoj Kaur Chawla,
>
> On 2015.03.19 20:05, Amitoj Kaur Chawla wrote:
> > The edits have been made to add a space before the comment and the errors in
> > braces in the if-else statements.
> > Previously in commit 2d34f53f1065878cd881ac61a183f8e836583d51, removed
> > the C99 comments and errors in if-else indentation and braces.
>
> The previous patch isn't in the git repo yet so it doesn't have a commit
> id thus this one is wrong. You should've just made a v2 and made that
> change. I recommend you to look over this:
> http://kernelnewbies.org/FirstKernelPatch Just remove the HEAD commit in
> your local git repo, add that space and then when using `git
> format-patch` use the "--subject-prefix" option to add that it's a
> second version. Then after "---" you can say what was changed in the
> second version. For example (I'm sure you can think of a better one!):
>
> Signed-off-by: ...
> ---
> v2: added a space after a statement in a line where a coding style error
> was fixed.
>
> drivers/...
Yes, please resend both of these.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-20 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-19 18:17 [PATCH] sm750fb: Fix Comment and if else braces Amitoj Kaur Chawla
2015-03-19 18:13 ` Giedrius Statkevičius
2015-03-20 13:04 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).