From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Colin King <colin.king@canonical.com>
Cc: kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org,
Maik Broemme <mbroemme@libmpq.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] video: fbdev: intelfb: remove redundant variables
Date: Thu, 09 Nov 2017 15:53:42 +0000 [thread overview]
Message-ID: <5552409.pVDogND5TS@amdc3058> (raw)
In-Reply-To: <20171106131711.6499-1-colin.king@canonical.com>
On Monday, November 06, 2017 01:17:11 PM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables err_max, err_target and f_best are being assigned values but
> these are never read, hence they are redundant variables and can be
> removed. Cleans up clang warnings:
>
> drivers/video/fbdev/intelfb/intelfbhw.c:946:2: warning: Value stored to
> 'err_max' is never read
> drivers/video/fbdev/intelfb/intelfbhw.c:947:2: warning: Value stored to
> 'err_target' is never read
> drivers/video/fbdev/intelfb/intelfbhw.c:995:6: warning: Value stored to
> 'f_best' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch queued for 4.15, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2017-11-09 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171106131737epcas3p2c8da62f9f262825461ca244b597a863f@epcas3p2.samsung.com>
2017-11-06 13:17 ` [PATCH] video: fbdev: intelfb: remove redundant variables Colin King
2017-11-09 15:53 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5552409.pVDogND5TS@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroemme@libmpq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).