From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Thomas Niederprüm" <niederp@physik.uni-kl.de>,
plagnioj@jcrosoft.com, maxime.ripard@free-electrons.com,
kernel@pengutronix.de, dan.carpenter@oracle.com,
prabhakar.csengg@gmail.com
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: ssd1307fb: fix logical error
Date: Tue, 26 May 2015 07:02:45 +0000 [thread overview]
Message-ID: <55641A95.1010102@ti.com> (raw)
In-Reply-To: <1432582161-14684-1-git-send-email-niederp@physik.uni-kl.de>
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
On 25/05/15 22:29, Thomas Niederprüm wrote:
> The logical not needs to be done after the bit masking.
>
> Fixes: a3998fe03e87 ("fbdev: ssd1307fb: Unify init code and obtain
> hw specific bits from DT")
>
> Signed-off-by: Thomas Niederprüm <niederp@physik.uni-kl.de>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/video/fbdev/ssd1307fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index 8fc224c..9771d56 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -368,7 +368,7 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
> if (ret < 0)
> return ret;
>
> - compins = 0x02 | (!par->com_seq & 0x1) << 4
> + compins = 0x02 | !(par->com_seq & 0x1) << 4
> | (par->com_lrremap & 0x1) << 5;
> ret = ssd1307fb_write_cmd(par->client, compins);
> if (ret < 0)
>
Thanks, queued for 4.2.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-05-26 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 19:29 [PATCH] fbdev: ssd1307fb: fix logical error Thomas Niederprüm
2015-05-26 7:02 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55641A95.1010102@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=niederp@physik.uni-kl.de \
--cc=plagnioj@jcrosoft.com \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).