From: In-Ki Dae <inki.dae@samsung.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "kmpark@infradead.org" <kmpark@infradead.org>,
"linux-fbdev-devel@lists.sourceforge.net"
<linux-fbdev-devel@lists.sourceforge.net>,
Ben Dooks <ben-linux@fluff.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: Re: [PATCH 1/3] FB: Add some members for CPU Interface.
Date: Fri, 02 Jul 2010 01:21:12 +0000 (GMT) [thread overview]
Message-ID: <5572310.15091278033672605.JavaMail.weblogic@epml12> (raw)
Hi, Andrew,
cpu timing variables could be used generically.
now fb.h and modedb.c file have been considered only for video mode.
but the way of transfering screen data includes also command mode(cpu mode or i80 mode)
so I thought it should be added things for it to fb_varscreeninfo struct.
Could you please tell me why cpu timing variables are specific to s3c-fb?
------- Original Message -------
Sender : Andrew Morton<akpm@linux-foundation.org>
Date : 2010-07-02 07:26 (GMT+09:00)
Title : Re: [PATCH 1/3] FB: Add some members for CPU Interface.
On Tue, 29 Jun 2010 19:28:14 +0900
InKi Dae <inki.dae@samsung.com> wrote:
>
> CPU interface needs cs, wr setup, wr act and hold delay.
> I added some members for them to common framework.
>
> Signed-off-by: InKi Dae <inki.dae@samsung.com <mailto:p.osciak@samsung.com>>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com
> <mailto:kyungmin.park@samsung.com>>
These email addresses are mangled.
> --- a/drivers/video/modedb.c
> +++ b/drivers/video/modedb.c
> ...
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
The patch seems pretty specific to s3c-fb. Is it possible and sensible
to somhow avoid adding code to generic files? Can we push more (or
all) of these changes into s3c-fb.c or into the arch/arm support code?
next reply other threads:[~2010-07-02 1:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 1:21 In-Ki Dae [this message]
2010-07-02 1:46 ` [PATCH 1/3] FB: Add some members for CPU Interface Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2010-07-02 2:35 In-Ki Dae
2010-06-30 0:02 Jaya Kumar
2010-07-02 1:51 ` In-Ki Dae
2010-07-02 7:50 ` In-Ki Dae
2010-07-06 16:09 ` James Simmons
2010-07-08 0:52 ` In-Ki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5572310.15091278033672605.JavaMail.weblogic@epml12 \
--to=inki.dae@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).