linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies
Date: Wed, 29 Jul 2015 11:27:07 +0000	[thread overview]
Message-ID: <55B8B88B.2070400@citrix.com> (raw)
In-Reply-To: <4EE5B48738DDED408878C97C8E050A8B1D7DDBB5@SJEXCHMB05.corp.ad.broadcom.com>

Hi Chris,

On 28/07/15 20:39, Chris (Christopher) Brand wrote:
>> Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant,
>> I suspect this is because the first support for Xen was for PV. This brough some
> Typo : "brought"
> Perhaps "resulted in" would be better ?
> 
>> misimplementation of helpers on ARM and make the developper confused the expected behavior.
> Typo: "developer".
> I'd also suggest "...and confused developers about the...".
> 
> [...]
> 
>> For clarity and avoid new confusion, replace any reference of mfn into gnf in any helpers used by PV drivers.
> Typo : "gfn"
> I'd suggest "...replace any reference to mfn with gfn..."
> 
> [...]

Thanks for telling me the typoes. I will fix it in the next version of
this series.

Regards,

-- 
Julien Grall

  reply	other threads:[~2015-07-29 11:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 15:02 [PATCH 0/8] Use correctly the Xen memory terminologies in Linux Julien Grall
2015-07-28 15:02 ` [PATCH 4/8] xen: Use the correctly the Xen memory terminologies Julien Grall
2015-07-28 17:16   ` [Xen-devel] " David Vrabel
2015-07-29 11:06     ` Julien Grall
2015-07-28 19:12   ` Boris Ostrovsky
2015-07-29 11:25     ` Julien Grall
2015-07-29 14:14       ` Boris Ostrovsky
2015-07-29 14:23         ` Julien Grall
2015-07-29 14:51           ` Boris Ostrovsky
2015-07-28 19:39   ` [Xen-devel] " Chris (Christopher) Brand
2015-07-29 11:27     ` Julien Grall [this message]
2015-07-29 10:13   ` Wei Liu
2015-07-29 11:35     ` [Xen-devel] " Julien Grall
2015-07-29 11:38       ` David Vrabel
2015-07-29 11:39       ` Wei Liu
2015-07-31 11:02   ` Stefano Stabellini
2015-07-28 15:02 ` [PATCH 6/8] video/xen-fbfront: Further s/MFN/GFN clean-up Julien Grall
2015-07-28 17:16   ` [Xen-devel] " David Vrabel
2015-07-28 21:06 ` [PATCH 0/8] Use correctly the Xen memory terminologies in Linux H. Peter Anvin
2015-07-28 21:12   ` [Xen-devel] " Andrew Cooper
2015-07-29 11:02 ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B8B88B.2070400@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).