From: Petr Cvek <petr.cvek@tul.cz>
To: linux-arm-kernel@lists.infradead.org
Subject: [BUG, RFC] Different bitfields in documentation and driver
Date: Fri, 07 Aug 2015 19:14:47 +0000 [thread overview]
Message-ID: <55C503A7.6020304@tul.cz> (raw)
Hello,
It seems that PXA2xx framebuffer has switched bitfields in nonstd definition (when using overlay).
This:
http://lxr.free-electrons.com/source/drivers/video/fbdev/pxafb.h#L80
versus this:
http://lxr.free-electrons.com/source/Documentation/fb/pxafb.txt#L128
Should be this changed in documentation or in driver? I was able to find only one use (in form of little outdated mplayer patch) and it fills both bitfields with zero (so potential change in driver will not break it).
P.S. Lack of overlay2's use is probably caused by errata "E24: LCD: Enabling Overlay 2 for YUV420 hangs LCD controller.", which is not workarounded in this driver. It should be mentioned in documentation and/or code, because the only way to start the LCD again is a full PXA SoC reset.
Petr Cvek
next reply other threads:[~2015-08-07 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 19:14 Petr Cvek [this message]
2015-08-08 16:56 ` [BUG, RFC] Different bitfields in documentation and driver Robert Jarzmik
2015-08-08 17:41 ` Petr Cvek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C503A7.6020304@tul.cz \
--to=petr.cvek@tul.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).