linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] video: fbdev: fsl: Fix the sleep function for FSL DIU module
@ 2015-08-14  5:54 Dongsheng Wang
  2015-08-15  3:45 ` Timur Tabi
  0 siblings, 1 reply; 6+ messages in thread
From: Dongsheng Wang @ 2015-08-14  5:54 UTC (permalink / raw)
  To: timur; +Cc: scottwood, Jason.Jin, linuxppc-dev, linux-fbdev, Wang Dongsheng

From: Jason Jin <Jason.Jin@freescale.com>

For deep sleep, the diu module will power off, when wake up
from the deep sleep, the registers need to be reinitialized.

Signed-off-by: Jason Jin <Jason.Jin@freescale.com>
Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
---
*v2*
Changes:
- int i -> unsigned int i.

Rmove:
- struct mfb_info *mfbi;

diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
index 7fa2e6f..b335c1a 100644
--- a/drivers/video/fbdev/fsl-diu-fb.c
+++ b/drivers/video/fbdev/fsl-diu-fb.c
@@ -1628,9 +1628,16 @@ static int fsl_diu_suspend(struct platform_device *ofdev, pm_message_t state)
 static int fsl_diu_resume(struct platform_device *ofdev)
 {
 	struct fsl_diu_data *data;
+	unsigned int i;
 
 	data = dev_get_drvdata(&ofdev->dev);
-	enable_lcdc(data->fsl_diu_info);
+
+	fsl_diu_enable_interrupts(data);
+	update_lcdc(data->fsl_diu_info);
+	for (i = 0; i < NUM_AOIS; i++) {
+		if (data->mfb[i].count)
+			fsl_diu_enable_panel(&data->fsl_diu_info[i]);
+	}
 
 	return 0;
 }
-- 
2.1.0.27.g96db324


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] video: fbdev: fsl: Fix the sleep function for FSL DIU module
  2015-08-14  5:54 [PATCH v2] video: fbdev: fsl: Fix the sleep function for FSL DIU module Dongsheng Wang
@ 2015-08-15  3:45 ` Timur Tabi
  2015-08-17  6:05   ` Wang Dongsheng
  2015-09-24 10:02   ` Wang Dongsheng
  0 siblings, 2 replies; 6+ messages in thread
From: Timur Tabi @ 2015-08-15  3:45 UTC (permalink / raw)
  To: Dongsheng Wang; +Cc: scottwood, Jason.Jin, linuxppc-dev, linux-fbdev

Dongsheng Wang wrote:
> For deep sleep, the diu module will power off, when wake up
> from the deep sleep, the registers need to be reinitialized.
>
> Signed-off-by: Jason Jin<Jason.Jin@freescale.com>
> Signed-off-by: Wang Dongsheng<dongsheng.wang@freescale.com>

Acked-by: Timur Tabi <timur@tabi.org>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH v2] video: fbdev: fsl: Fix the sleep function for FSL DIU module
  2015-08-15  3:45 ` Timur Tabi
@ 2015-08-17  6:05   ` Wang Dongsheng
  2015-08-17 12:31     ` Timur Tabi
  2015-09-24 10:02   ` Wang Dongsheng
  1 sibling, 1 reply; 6+ messages in thread
From: Wang Dongsheng @ 2015-08-17  6:05 UTC (permalink / raw)
  To: Timur Tabi, Scott Wood
  Cc: Jin Jason, linuxppc-dev@lists.ozlabs.org,
	linux-fbdev@vger.kernel.org

Thanks Timur.

@Scott,
Could you apply this patch?

Regards,
-Dongsheng

> -----Original Message-----
> From: Timur Tabi [mailto:timur@tabi.org]
> Sent: Saturday, August 15, 2015 11:45 AM
> To: Wang Dongsheng-B40534
> Cc: Wood Scott-B07421; Jin Zhengxiong-R64188; linuxppc-dev@lists.ozlabs.org;
> linux-fbdev@vger.kernel.org
> Subject: Re: [PATCH v2] video: fbdev: fsl: Fix the sleep function for FSL DIU
> module
> 
> Dongsheng Wang wrote:
> > For deep sleep, the diu module will power off, when wake up from the
> > deep sleep, the registers need to be reinitialized.
> >
> > Signed-off-by: Jason Jin<Jason.Jin@freescale.com>
> > Signed-off-by: Wang Dongsheng<dongsheng.wang@freescale.com>
> 
> Acked-by: Timur Tabi <timur@tabi.org>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] video: fbdev: fsl: Fix the sleep function for FSL DIU module
  2015-08-17  6:05   ` Wang Dongsheng
@ 2015-08-17 12:31     ` Timur Tabi
  0 siblings, 0 replies; 6+ messages in thread
From: Timur Tabi @ 2015-08-17 12:31 UTC (permalink / raw)
  To: Wang Dongsheng, Scott Wood
  Cc: Jin Jason, linuxppc-dev@lists.ozlabs.org,
	linux-fbdev@vger.kernel.org

Wang Dongsheng wrote:
> Thanks Timur.
>
> @Scott,
> Could you apply this patch?

You need to ask the fbdev maintainer to apply it, because it has to go 
through his tree.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH v2] video: fbdev: fsl: Fix the sleep function for FSL DIU module
  2015-08-15  3:45 ` Timur Tabi
  2015-08-17  6:05   ` Wang Dongsheng
@ 2015-09-24 10:02   ` Wang Dongsheng
  2015-09-24 10:07     ` Tomi Valkeinen
  1 sibling, 1 reply; 6+ messages in thread
From: Wang Dongsheng @ 2015-09-24 10:02 UTC (permalink / raw)
  To: tomi.valkeinen@ti.com
  Cc: Scott Wood, Jin Jason, linuxppc-dev@lists.ozlabs.org,
	linux-fbdev@vger.kernel.org, Timur Tabi

Hi Tomi,

Could you apply this patch?

> > For deep sleep, the diu module will power off, when wake up from the
> > deep sleep, the registers need to be reinitialized.
> >
> > Signed-off-by: Jason Jin<Jason.Jin@freescale.com>
> > Signed-off-by: Wang Dongsheng<dongsheng.wang@freescale.com>
> 
> Acked-by: Timur Tabi <timur@tabi.org>

Regards,
-Dongsheng

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] video: fbdev: fsl: Fix the sleep function for FSL DIU module
  2015-09-24 10:02   ` Wang Dongsheng
@ 2015-09-24 10:07     ` Tomi Valkeinen
  0 siblings, 0 replies; 6+ messages in thread
From: Tomi Valkeinen @ 2015-09-24 10:07 UTC (permalink / raw)
  To: Wang Dongsheng
  Cc: Scott Wood, Jin Jason, linuxppc-dev@lists.ozlabs.org,
	linux-fbdev@vger.kernel.org, Timur Tabi

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]



On 24/09/15 13:02, Wang Dongsheng wrote:
> Hi Tomi,
> 
> Could you apply this patch?
> 
>>> For deep sleep, the diu module will power off, when wake up from the
>>> deep sleep, the registers need to be reinitialized.
>>>
>>> Signed-off-by: Jason Jin<Jason.Jin@freescale.com>
>>> Signed-off-by: Wang Dongsheng<dongsheng.wang@freescale.com>
>>
>> Acked-by: Timur Tabi <timur@tabi.org>

Thanks, queued for 4.3 fixes.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-09-24 10:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-14  5:54 [PATCH v2] video: fbdev: fsl: Fix the sleep function for FSL DIU module Dongsheng Wang
2015-08-15  3:45 ` Timur Tabi
2015-08-17  6:05   ` Wang Dongsheng
2015-08-17 12:31     ` Timur Tabi
2015-09-24 10:02   ` Wang Dongsheng
2015-09-24 10:07     ` Tomi Valkeinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).