* [PATCH RESEND] video: fbdev: s3c-fb: Constify platform_device_id
@ 2015-07-07 13:00 Krzysztof Kozlowski
2015-07-08 4:34 ` Jingoo Han
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-07 13:00 UTC (permalink / raw)
To: Jingoo Han, Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
linux-fbdev, linux-kernel
Cc: Krzysztof Kozlowski
The platform_device_id is not modified by the driver and core uses it as
const.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
---
drivers/video/fbdev/s3c-fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index 7e3a05fc47aa..f72dd12456f9 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = {
},
};
-static struct platform_device_id s3c_fb_driver_ids[] = {
+static const struct platform_device_id s3c_fb_driver_ids[] = {
{
.name = "s3c-fb",
.driver_data = (unsigned long)&s3c_fb_data_64xx,
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] video: fbdev: s3c-fb: Constify platform_device_id
2015-07-07 13:00 [PATCH RESEND] video: fbdev: s3c-fb: Constify platform_device_id Krzysztof Kozlowski
@ 2015-07-08 4:34 ` Jingoo Han
2015-07-24 6:12 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Jingoo Han @ 2015-07-08 4:34 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jingoohan1
On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski <k.kozlowski.k@gmail.com> wrote:
>
> The platform_device_id is not modified by the driver and core uses it as
> const.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
> ---
> drivers/video/fbdev/s3c-fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 7e3a05fc47aa..f72dd12456f9 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = {
> },
> };
>
> -static struct platform_device_id s3c_fb_driver_ids[] = {
> +static const struct platform_device_id s3c_fb_driver_ids[] = {
> {
> .name = "s3c-fb",
> .driver_data = (unsigned long)&s3c_fb_data_64xx,
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] video: fbdev: s3c-fb: Constify platform_device_id
2015-07-08 4:34 ` Jingoo Han
@ 2015-07-24 6:12 ` Krzysztof Kozlowski
2015-08-20 9:16 ` Tomi Valkeinen
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-24 6:12 UTC (permalink / raw)
To: Jingoo Han
Cc: Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
2015-07-08 13:34 GMT+09:00 Jingoo Han <jingoohan1@gmail.com>:
>
> On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski <k.kozlowski.k@gmail.com> wrote:
>>
>> The platform_device_id is not modified by the driver and core uses it as
>> const.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
>
> Acked-by: Jingoo Han <jingoohan1@gmail.com>
>
> Best regards,
> Jingoo Han
Seems nobody is picking it up, so I merge it through Samsung-SoC tree.
If there are any objections please let me know.
Best regards,
Krzysztof
>
>> ---
>> drivers/video/fbdev/s3c-fb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
>> index 7e3a05fc47aa..f72dd12456f9 100644
>> --- a/drivers/video/fbdev/s3c-fb.c
>> +++ b/drivers/video/fbdev/s3c-fb.c
>> @@ -1938,7 +1938,7 @@ static struct s3c_fb_driverdata s3c_fb_data_s3c2443 = {
>> },
>> };
>>
>> -static struct platform_device_id s3c_fb_driver_ids[] = {
>> +static const struct platform_device_id s3c_fb_driver_ids[] = {
>> {
>> .name = "s3c-fb",
>> .driver_data = (unsigned long)&s3c_fb_data_64xx,
>> --
>> 2.1.4
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] video: fbdev: s3c-fb: Constify platform_device_id
2015-07-24 6:12 ` Krzysztof Kozlowski
@ 2015-08-20 9:16 ` Tomi Valkeinen
2015-08-21 1:46 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Tomi Valkeinen @ 2015-08-20 9:16 UTC (permalink / raw)
To: Krzysztof Kozlowski, Jingoo Han
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
On 24/07/15 09:12, Krzysztof Kozlowski wrote:
> 2015-07-08 13:34 GMT+09:00 Jingoo Han <jingoohan1@gmail.com>:
>>
>> On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski <k.kozlowski.k@gmail.com> wrote:
>>>
>>> The platform_device_id is not modified by the driver and core uses it as
>>> const.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
>>
>> Acked-by: Jingoo Han <jingoohan1@gmail.com>
>>
>> Best regards,
>> Jingoo Han
>
> Seems nobody is picking it up, so I merge it through Samsung-SoC tree.
> If there are any objections please let me know.
I can pick this up if you didn't already do that.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] video: fbdev: s3c-fb: Constify platform_device_id
2015-08-20 9:16 ` Tomi Valkeinen
@ 2015-08-21 1:46 ` Krzysztof Kozlowski
2015-08-21 5:57 ` Tomi Valkeinen
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-08-21 1:46 UTC (permalink / raw)
To: Tomi Valkeinen, Jingoo Han
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
On 20.08.2015 18:16, Tomi Valkeinen wrote:
>
>
> On 24/07/15 09:12, Krzysztof Kozlowski wrote:
>> 2015-07-08 13:34 GMT+09:00 Jingoo Han <jingoohan1@gmail.com>:
>>>
>>> On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski <k.kozlowski.k@gmail.com> wrote:
>>>>
>>>> The platform_device_id is not modified by the driver and core uses it as
>>>> const.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
>>>
>>> Acked-by: Jingoo Han <jingoohan1@gmail.com>
>>>
>>> Best regards,
>>> Jingoo Han
>>
>> Seems nobody is picking it up, so I merge it through Samsung-SoC tree.
>> If there are any objections please let me know.
>
> I can pick this up if you didn't already do that.
Could you? It would be great.
Kukjin did not pick it up so it is still waiting for some attention. :)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] video: fbdev: s3c-fb: Constify platform_device_id
2015-08-21 1:46 ` Krzysztof Kozlowski
@ 2015-08-21 5:57 ` Tomi Valkeinen
0 siblings, 0 replies; 6+ messages in thread
From: Tomi Valkeinen @ 2015-08-21 5:57 UTC (permalink / raw)
To: Krzysztof Kozlowski, Jingoo Han
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
On 21/08/15 04:46, Krzysztof Kozlowski wrote:
> On 20.08.2015 18:16, Tomi Valkeinen wrote:
>>
>>
>> On 24/07/15 09:12, Krzysztof Kozlowski wrote:
>>> 2015-07-08 13:34 GMT+09:00 Jingoo Han <jingoohan1@gmail.com>:
>>>>
>>>> On 2015. 7. 7., at PM 10:00, Krzysztof Kozlowski <k.kozlowski.k@gmail.com> wrote:
>>>>>
>>>>> The platform_device_id is not modified by the driver and core uses it as
>>>>> const.
>>>>>
>>>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
>>>>
>>>> Acked-by: Jingoo Han <jingoohan1@gmail.com>
>>>>
>>>> Best regards,
>>>> Jingoo Han
>>>
>>> Seems nobody is picking it up, so I merge it through Samsung-SoC tree.
>>> If there are any objections please let me know.
>>
>> I can pick this up if you didn't already do that.
>
> Could you? It would be great.
> Kukjin did not pick it up so it is still waiting for some attention. :)
Ok. I've queued this for 4.3.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-08-21 5:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-07 13:00 [PATCH RESEND] video: fbdev: s3c-fb: Constify platform_device_id Krzysztof Kozlowski
2015-07-08 4:34 ` Jingoo Han
2015-07-24 6:12 ` Krzysztof Kozlowski
2015-08-20 9:16 ` Tomi Valkeinen
2015-08-21 1:46 ` Krzysztof Kozlowski
2015-08-21 5:57 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).