* [PATCH] backlight: lp855x: Make sure props struct is zeroed
@ 2015-08-27 17:41 Bjorn Andersson
2015-08-27 22:44 ` Kim, Milo
2015-09-19 10:06 ` Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Bjorn Andersson @ 2015-08-27 17:41 UTC (permalink / raw)
To: Milo Kim, Jingoo Han, Lee Jones, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen
Cc: linux-fbdev, linux-kernel, Werner Johansson
From: Werner Johansson <werner.johansson@sonymobile.com>
The driver occasionally got stuck in suspend mode or other strange
states as those parts of the props struct were never initialized.
Signed-off-by: Werner Johansson <werner.johansson@sonymobile.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
drivers/video/backlight/lp855x_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index 88116b493f3b..0a7f88ce1ab0 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -282,6 +282,7 @@ static int lp855x_backlight_register(struct lp855x *lp)
struct lp855x_platform_data *pdata = lp->pdata;
const char *name = pdata->name ? : DEFAULT_BL_NAME;
+ memset(&props, 0, sizeof(props));
props.type = BACKLIGHT_PLATFORM;
props.max_brightness = MAX_BRIGHTNESS;
--
1.8.2.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] backlight: lp855x: Make sure props struct is zeroed
2015-08-27 17:41 [PATCH] backlight: lp855x: Make sure props struct is zeroed Bjorn Andersson
@ 2015-08-27 22:44 ` Kim, Milo
2015-08-27 22:51 ` Johansson, Werner
2015-09-19 10:06 ` Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Kim, Milo @ 2015-08-27 22:44 UTC (permalink / raw)
To: Bjorn Andersson, Werner Johansson
Cc: Jingoo Han, Lee Jones, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, linux-fbdev, linux-kernel
On 8/28/2015 2:41 AM, Bjorn Andersson wrote:
> From: Werner Johansson <werner.johansson@sonymobile.com>
>
> The driver occasionally got stuck in suspend mode or other strange
> states as those parts of the props struct were never initialized.
Acked-by: Milo Kim <milo.kim@ti.com>
Thanks for catching this.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] backlight: lp855x: Make sure props struct is zeroed
2015-08-27 22:44 ` Kim, Milo
@ 2015-08-27 22:51 ` Johansson, Werner
0 siblings, 0 replies; 4+ messages in thread
From: Johansson, Werner @ 2015-08-27 22:51 UTC (permalink / raw)
To: Kim, Milo, "Andersson, Björn"
Cc: Jingoo Han, Lee Jones, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
> > From: Werner Johansson <werner.johansson@sonymobile.com>
> >
> > The driver occasionally got stuck in suspend mode or other strange
> > states as those parts of the props struct were never initialized.
>
> Acked-by: Milo Kim <milo.kim@ti.com>
>
> Thanks for catching this.
You're most welcome! These issues can be difficult to track down, the stack is unpredictable..
/wj
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] backlight: lp855x: Make sure props struct is zeroed
2015-08-27 17:41 [PATCH] backlight: lp855x: Make sure props struct is zeroed Bjorn Andersson
2015-08-27 22:44 ` Kim, Milo
@ 2015-09-19 10:06 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2015-09-19 10:06 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Milo Kim, Jingoo Han, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, linux-fbdev, linux-kernel, Werner Johansson
On Thu, 27 Aug 2015, Bjorn Andersson wrote:
> From: Werner Johansson <werner.johansson@sonymobile.com>
>
> The driver occasionally got stuck in suspend mode or other strange
> states as those parts of the props struct were never initialized.
>
> Signed-off-by: Werner Johansson <werner.johansson@sonymobile.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
> drivers/video/backlight/lp855x_bl.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index 88116b493f3b..0a7f88ce1ab0 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -282,6 +282,7 @@ static int lp855x_backlight_register(struct lp855x *lp)
> struct lp855x_platform_data *pdata = lp->pdata;
> const char *name = pdata->name ? : DEFAULT_BL_NAME;
>
> + memset(&props, 0, sizeof(props));
> props.type = BACKLIGHT_PLATFORM;
> props.max_brightness = MAX_BRIGHTNESS;
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-19 10:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-27 17:41 [PATCH] backlight: lp855x: Make sure props struct is zeroed Bjorn Andersson
2015-08-27 22:44 ` Kim, Milo
2015-08-27 22:51 ` Johansson, Werner
2015-09-19 10:06 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).