From: Jyri Sarha <jsarha@ti.com>
To: alsa-devel@alsa-project.org, linux-fbdev@vger.kernel.org,
linux-omap@vger.kernel.org
Cc: peter.ujfalusi@ti.com, tomi.valkeinen@ti.com
Subject: Re: [PATCH v2] OMAPDSS: hdmi: Reconfigure and restart audio when display is enabled
Date: Fri, 28 Aug 2015 12:57:40 +0000 [thread overview]
Message-ID: <55E05AC4.1030206@ti.com> (raw)
In-Reply-To: <1440764660-10417-1-git-send-email-jsarha@ti.com>
On 08/28/15 15:24, Jyri Sarha wrote:
> @@ -565,9 +594,14 @@ out:
> static int hdmi_audio_shutdown(struct device *dev)
> {
> struct omap_hdmi *hd = dev_get_drvdata(dev);
> + unsigned long flags;
>
> mutex_lock(&hd->lock);
> hd->audio_abort_cb = NULL;
> + hd->audio_configured = false;
> + spin_lock_irqsave(&hd->audio_playing_lock, flags);
> + hd->audio_playing = false;
> + spin_unlock_irqrestore(&hd->audio_playing_lock, flags);
>
BTW, This extra locking (and the corresponding change in hdmi5.c) should
not be needed. But it does not harm either. I'll fix that, but I'll wait
first if there is anything else fix.
Best regards,
Jyri
next prev parent reply other threads:[~2015-08-28 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 12:24 [PATCH v2] OMAPDSS: hdmi: Reconfigure and restart audio when display is enabled Jyri Sarha
2015-08-28 12:57 ` Jyri Sarha [this message]
2015-08-28 13:04 ` Tomi Valkeinen
2015-08-28 13:46 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E05AC4.1030206@ti.com \
--to=jsarha@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).