From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCHv2 3/3] devicetree: Add led-backlight binding
Date: Wed, 09 Sep 2015 11:47:08 +0000 [thread overview]
Message-ID: <55F01C3C.5030406@ti.com> (raw)
In-Reply-To: <20150908134140.GH30736@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]
On 08/09/15 16:41, Andrew Lunn wrote:
> On Tue, Sep 08, 2015 at 02:19:36PM +0300, Tomi Valkeinen wrote:
>> Add DT binding for led-backlight.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> ---
>> .../bindings/video/backlight/led-backlight.txt | 30 ++++++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/video/backlight/led-backlight.txt
>>
>> diff --git a/Documentation/devicetree/bindings/video/backlight/led-backlight.txt b/Documentation/devicetree/bindings/video/backlight/led-backlight.txt
>> new file mode 100644
>> index 000000000000..fb77051ac230
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/video/backlight/led-backlight.txt
>> @@ -0,0 +1,30 @@
>> +led-backlight bindings
>> +
>> +Required properties:
>> + - compatible: "led-backlight"
>> + - leds: phandle to a led OF node [0]
>> + - brightness-levels: Array of distinct LED brightness levels. These
>> + are in the range from 0 to 255, passed to the LED class driver.
>> + - default-brightness-level: the default brightness level (index into the
>> + array defined by the "brightness-levels" property)
>> + - power-supply: regulator for supply voltage
>
> Hi Tomi
>
> Maybe this regulator should be optional? I could imagine blacklights
> without one, in none power sensitive cases, e.g. industrial PC with a
> touch screen display, train ticket machine, etc.
Yes, I think so. Especially in this case as this led-backlight device is
not exactly a specific HW device, but more of a virtual device.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-09-09 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 11:19 [PATCHv2 0/3] backlight: led-backlight driver Tomi Valkeinen
2015-09-08 11:19 ` [PATCHv2 1/3] leds: Add of_led_get() and led_put() Tomi Valkeinen
2015-09-08 13:20 ` Jacek Anaszewski
2015-09-08 14:04 ` Jacek Anaszewski
2015-09-09 12:16 ` Tomi Valkeinen
2015-09-09 12:40 ` Jacek Anaszewski
2015-09-09 12:00 ` Tomi Valkeinen
2015-09-08 11:19 ` [PATCHv2 2/3] backlight: add led-backlight driver Tomi Valkeinen
2015-09-08 11:19 ` [PATCHv2 3/3] devicetree: Add led-backlight binding Tomi Valkeinen
2015-09-08 13:41 ` Andrew Lunn
2015-09-09 11:47 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F01C3C.5030406@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=andrew@lunn.ch \
--cc=j.anaszewski@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).