* [PATCH] omapdss: acx565akm: Fix module autoload for OF platform driver
@ 2015-09-18 18:44 Luis de Bethencourt
2015-09-24 10:17 ` Tomi Valkeinen
0 siblings, 1 reply; 3+ messages in thread
From: Luis de Bethencourt @ 2015-09-18 18:44 UTC (permalink / raw)
To: linux-kernel
Cc: Tomi Valkeinen, Jean-Christophe Plagniol-Villard, linux-omap,
linux-fbdev
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
Hello,
This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.
A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519
Thanks,
Luis
drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
index 90cbc4c..c581231 100644
--- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
+++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
@@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = {
{ .compatible = "omapdss,sony,acx565akm", },
{},
};
+MODULE_DEVICE_TABLE(of, acx565akm_of_match);
static struct spi_driver acx565akm_driver = {
.driver = {
--
2.4.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] omapdss: acx565akm: Fix module autoload for OF platform driver
2015-09-18 18:44 [PATCH] omapdss: acx565akm: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-24 10:17 ` Tomi Valkeinen
2015-09-24 11:37 ` Tomi Valkeinen
0 siblings, 1 reply; 3+ messages in thread
From: Tomi Valkeinen @ 2015-09-24 10:17 UTC (permalink / raw)
To: Luis de Bethencourt, linux-kernel
Cc: Jean-Christophe Plagniol-Villard, linux-omap, linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
On 18/09/15 21:44, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hello,
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
>
> Thanks,
> Luis
>
> drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> index 90cbc4c..c581231 100644
> --- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> +++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> @@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = {
> { .compatible = "omapdss,sony,acx565akm", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, acx565akm_of_match);
>
> static struct spi_driver acx565akm_driver = {
> .driver = {
>
Thanks, queued for 4.3 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] omapdss: acx565akm: Fix module autoload for OF platform driver
2015-09-24 10:17 ` Tomi Valkeinen
@ 2015-09-24 11:37 ` Tomi Valkeinen
0 siblings, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2015-09-24 11:37 UTC (permalink / raw)
To: Luis de Bethencourt, linux-kernel
Cc: Jean-Christophe Plagniol-Villard, linux-omap, linux-fbdev,
Javier Martinez Canillas
[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]
On 24/09/15 13:17, Tomi Valkeinen wrote:
>
>
> On 18/09/15 21:44, Luis de Bethencourt wrote:
>> This platform driver has a OF device ID table but the OF module
>> alias information is not created so module autoloading won't work.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>> ---
>>
>> Hello,
>>
>> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
>> that information so modules have the correct aliases built-in and
>> autoloading works correctly.
>>
>> A longer explanation by Javier Canillas can be found here:
>> https://lkml.org/lkml/2015/7/30/519
>>
>> Thanks,
>> Luis
>>
>> drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
>> index 90cbc4c..c581231 100644
>> --- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
>> +++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
>> @@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = {
>> { .compatible = "omapdss,sony,acx565akm", },
>> {},
>> };
>> +MODULE_DEVICE_TABLE(of, acx565akm_of_match);
>>
>> static struct spi_driver acx565akm_driver = {
>> .driver = {
>>
>
> Thanks, queued for 4.3 fixes.
Oh, there was an earlier patch from Javier already posted. So I'll pick
that one instead.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-24 11:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-18 18:44 [PATCH] omapdss: acx565akm: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-24 10:17 ` Tomi Valkeinen
2015-09-24 11:37 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).