From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-leds@vger.kernel.org, linux-fbdev@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCHv3 1/3] leds: Add of_led_get() and led_put()
Date: Mon, 28 Sep 2015 08:08:50 +0000 [thread overview]
Message-ID: <5608F592.7010008@ti.com> (raw)
In-Reply-To: <55F2DC3C.6090100@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On 11/09/15 16:50, Jacek Anaszewski wrote:
>> +/**
>> + * led_put() - release a LED device, reserved with led_get()
>
> s/led_get/of_led_get/
>
> or we should add led_get, but since class_find_device, which increments
> device ref count, takes led_node and led_match_led_node, it is tightly
> coupled tightly with OF. OTOH we could have of_led_put for symmetry,
> but it would have nothing to do with OF. Amending the comment is the
> best option here, I think.
I agree. I've changed the comment.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-28 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 13:07 [PATCHv3 0/3] backlight: led-backlight driver Tomi Valkeinen
2015-09-11 13:07 ` [PATCHv3 1/3] leds: Add of_led_get() and led_put() Tomi Valkeinen
2015-09-11 13:50 ` Jacek Anaszewski
2015-09-28 8:08 ` Tomi Valkeinen [this message]
2015-09-11 13:07 ` [PATCHv3 2/3] backlight: add led-backlight driver Tomi Valkeinen
2015-09-28 8:12 ` Tomi Valkeinen
2015-09-28 10:31 ` Lee Jones
2015-09-11 13:07 ` [PATCHv3 3/3] devicetree: Add led-backlight binding Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5608F592.7010008@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=andrew@lunn.ch \
--cc=j.anaszewski@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).