Re: [PATCH] video: fbdev: fsl: fix kernel crash when diu_ops is not implemented

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]



On 24/11/15 18:04, Timur Tabi wrote:
> On Tue, Nov 24, 2015 at 5:46 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> On 24/11/15 08:27, Dongsheng Wang wrote:
>>> @@ -1697,6 +1700,9 @@ static int fsl_diu_probe(struct platform_device *pdev)
>>>       unsigned int i;
>>>       int ret;
>>>
>>> +     if (!diu_ops.set_pixel_clock)
>>> +             return -ENODEV;
>>> +
>>>       data = dmam_alloc_coherent(&pdev->dev, sizeof(struct fsl_diu_data),
>>>                                  &dma_addr, GFP_DMA | __GFP_ZERO);
>>>       if (!data)
>>>
>>
>> Thanks, queued for 4.5.
> 
> Could you please wait for me to review the patch first?  I am the
> maintainer for the driver, and I see a problem with it.

Sorry, I was too hasty (and tired). I thought I was looking at a patch
that's been on the list for a while, but apparently it was only posted
today...

Anyway, dropped this.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]