* [PATCH] video: fbdev: rivafb: unlock chip before probiding EDID
@ 2015-11-17 1:38 Dmitry Eremin-Solenikov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Eremin-Solenikov @ 2015-11-17 1:38 UTC (permalink / raw)
To: linux-fbdev
At least NV3 requires for chip to be unlocked before it is possible to
access I2C registers. Without it, it is not possible to read EDID.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
drivers/video/fbdev/riva/fbdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c
index f1ad274..2ef26ad 100644
--- a/drivers/video/fbdev/riva/fbdev.c
+++ b/drivers/video/fbdev/riva/fbdev.c
@@ -1765,6 +1765,7 @@ static int riva_get_EDID_i2c(struct fb_info *info)
int i;
NVTRACE_ENTER();
+ par->riva.LockUnlock(&par->riva, 0);
riva_create_i2c_busses(par);
for (i = 0; i < 3; i++) {
if (!par->chan[i].par)
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: rivafb: unlock chip before probiding EDID
@ 2015-12-07 16:29 Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2015-12-07 16:29 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On 17/11/15 03:38, Dmitry Eremin-Solenikov wrote:
> At least NV3 requires for chip to be unlocked before it is possible to
> access I2C registers. Without it, it is not possible to read EDID.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
> drivers/video/fbdev/riva/fbdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c
> index f1ad274..2ef26ad 100644
> --- a/drivers/video/fbdev/riva/fbdev.c
> +++ b/drivers/video/fbdev/riva/fbdev.c
> @@ -1765,6 +1765,7 @@ static int riva_get_EDID_i2c(struct fb_info *info)
> int i;
>
> NVTRACE_ENTER();
> + par->riva.LockUnlock(&par->riva, 0);
> riva_create_i2c_busses(par);
> for (i = 0; i < 3; i++) {
> if (!par->chan[i].par)
>
Thanks, applied for 4.5.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-07 16:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-07 16:29 [PATCH] video: fbdev: rivafb: unlock chip before probiding EDID Tomi Valkeinen
-- strict thread matches above, loose matches on Subject: below --
2015-11-17 1:38 Dmitry Eremin-Solenikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).