[PATCH v2 2/3] fbdev: omap2: panel-dpi: make (limited) use of a reset gpio

[PATCH v2 2/3] fbdev: omap2: panel-dpi: make (limited) use of a reset gpio

[Uwe Kleine-König]

Some displays have a reset input. To assert that the display is
functional the reset gpio must be deasserted.

Teach the driver to get and drive such a gpio accordingly.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
--
Changes since (implicit) v1, sent with
Message-Id: 1449753107-11410-4-git-send-email-uwe@kleine-koenig.org :

 - never assert reset because there are too many different panels with
   too many different needs for their reset.
 - split out dt binding changes
 - reword commit log
---
 drivers/video/fbdev/omap2/displays-new/panel-dpi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c
index e780fd4f8b46..201a1c1a6f42 100644
--- a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c
+++ b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c
@@ -213,6 +213,16 @@ static int panel_dpi_probe_of(struct platform_device *pdev)
 
 	ddata->enable_gpio = gpio;
 
+	/*
+	 * Many different panels are supported by this driver and there are
+	 * probably very different needs for their reset pins in regards to
+	 * timing and order relative to the enable gpio. So for now it's just
+	 * ensured that the reset line isn't active.
+	 */
+	gpio = devm_gpiod_get_optional(&pdev->dev, "reset", GPIOD_OUT_LOW);
+	if (IS_ERR(gpio))
+		return PTR_ERR(gpio);
+
 	ddata->backlight_gpio = -ENOENT;
 
 	r = of_get_display_timing(node, "panel-timing", &timing);
-- 
2.6.2

Re: [PATCH v2 2/3] fbdev: omap2: panel-dpi: make (limited) use of a reset gpio

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]


On 20/12/15 13:13, Uwe Kleine-König wrote:
> Some displays have a reset input. To assert that the display is
> functional the reset gpio must be deasserted.
> 
> Teach the driver to get and drive such a gpio accordingly.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> --
> Changes since (implicit) v1, sent with
> Message-Id: 1449753107-11410-4-git-send-email-uwe@kleine-koenig.org :
> 
>  - never assert reset because there are too many different panels with
>    too many different needs for their reset.
>  - split out dt binding changes
>  - reword commit log

Please add these extra texts below the --- line below. Otherwise they
end up in the commit description.

> ---
>  drivers/video/fbdev/omap2/displays-new/panel-dpi.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c
> index e780fd4f8b46..201a1c1a6f42 100644
> --- a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c
> +++ b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c
> @@ -213,6 +213,16 @@ static int panel_dpi_probe_of(struct platform_device *pdev)
>  
>  	ddata->enable_gpio = gpio;
>  
> +	/*
> +	 * Many different panels are supported by this driver and there are
> +	 * probably very different needs for their reset pins in regards to
> +	 * timing and order relative to the enable gpio. So for now it's just
> +	 * ensured that the reset line isn't active.
> +	 */
> +	gpio = devm_gpiod_get_optional(&pdev->dev, "reset", GPIOD_OUT_LOW);
> +	if (IS_ERR(gpio))
> +		return PTR_ERR(gpio);
> +
>  	ddata->backlight_gpio = -ENOENT;
>  
>  	r = of_get_display_timing(node, "panel-timing", &timing);
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v2 2/3] fbdev: omap2: panel-dpi: make (limited) use of a reset gpio

[Uwe Kleine-König]

On Tue, Feb 16, 2016 at 03:01:55PM +0200, Tomi Valkeinen wrote:
> 
> On 20/12/15 13:13, Uwe Kleine-König wrote:
> > Some displays have a reset input. To assert that the display is
> > functional the reset gpio must be deasserted.
> > 
> > Teach the driver to get and drive such a gpio accordingly.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > --
> > Changes since (implicit) v1, sent with
> > Message-Id: 1449753107-11410-4-git-send-email-uwe@kleine-koenig.org :
> > 
> >  - never assert reset because there are too many different panels with
> >    too many different needs for their reset.
> >  - split out dt binding changes
> >  - reword commit log
> 
> Please add these extra texts below the --- line below. Otherwise they
> end up in the commit description.

This was an accident. Should I resend for that one?

Best regards
Uwe

Re: [PATCH v2 2/3] fbdev: omap2: panel-dpi: make (limited) use of a reset gpio

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]


On 16/02/16 15:31, Uwe Kleine-König wrote:
> On Tue, Feb 16, 2016 at 03:01:55PM +0200, Tomi Valkeinen wrote:
>>
>> On 20/12/15 13:13, Uwe Kleine-König wrote:
>>> Some displays have a reset input. To assert that the display is
>>> functional the reset gpio must be deasserted.
>>>
>>> Teach the driver to get and drive such a gpio accordingly.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>> --
>>> Changes since (implicit) v1, sent with
>>> Message-Id: 1449753107-11410-4-git-send-email-uwe@kleine-koenig.org :
>>>
>>>  - never assert reset because there are too many different panels with
>>>    too many different needs for their reset.
>>>  - split out dt binding changes
>>>  - reword commit log
>>
>> Please add these extra texts below the --- line below. Otherwise they
>> end up in the commit description.
> 
> This was an accident. Should I resend for that one?

If there are other changes to other patches, resend the series. If there
are no other changes, I can just snip it out.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]