From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] fbdev: kill fb_rotate
Date: Fri, 26 Feb 2016 11:30:54 +0000 [thread overview]
Message-ID: <56D0376E.6070908@ti.com> (raw)
In-Reply-To: <1455044172-17488-1-git-send-email-linux@rasmusvillemoes.dk>
[-- Attachment #1.1: Type: text/plain, Size: 934 bytes --]
On 09/02/16 20:56, Rasmus Villemoes wrote:
> The fb_rotate method in struct fb_ops is never actually invoked, and
> it's been that way in the entire history of git (in fact, the last
> occurrence of the string '->fb_rotate' vanished over 10 years ago,
> with b4d8aea6d6, and that merely tested whether the callback
> existed). So remove some dead code and make struct fb_obs a little
> smaller.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/video/fbdev/atafb.c | 3 ---
> drivers/video/fbdev/au1100fb.c | 22 ----------------------
> drivers/video/fbdev/bf537-lq035.c | 23 -----------------------
> drivers/video/fbdev/omap/omapfb_main.c | 22 ----------------------
> drivers/video/fbdev/skeletonfb.c | 17 -----------------
> include/linux/fb.h | 3 ---
> 6 files changed, 90 deletions(-)
Thanks, queued for 4.6.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-02-26 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 21:16 Kill ->fb_rotate? Rasmus Villemoes
2016-02-09 18:56 ` [PATCH] fbdev: kill fb_rotate Rasmus Villemoes
2016-02-26 11:30 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D0376E.6070908@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).