From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Mon, 07 Mar 2016 18:29:21 +0000 Subject: Re: [PATCH 1/5] Subject: video: goldfishfb: add devicetree bindings Message-Id: <56DDC881.6060603@ti.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="ClVIm2AiWOlI1EUhGqGk0etOfPia2te6M" List-Id: References: <20160226183940.2731.42083.stgit@localhost.localdomain> <20160226184146.2731.41848.stgit@localhost.localdomain> In-Reply-To: <20160226184146.2731.41848.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> To: Alan , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" --ClVIm2AiWOlI1EUhGqGk0etOfPia2te6M Content-Type: multipart/mixed; boundary="0XkHs8j1o2DMM6L5262LlJIwn5VfrEH2u" From: Tomi Valkeinen To: Alan , linux-fbdev@vger.kernel.org, plagnioj@jcrosoft.com, "devicetree@vger.kernel.org" Message-ID: <56DDC881.6060603@ti.com> Subject: Re: [PATCH 1/5] Subject: video: goldfishfb: add devicetree bindings References: <20160226183940.2731.42083.stgit@localhost.localdomain> <20160226184146.2731.41848.stgit@localhost.localdomain> In-Reply-To: <20160226184146.2731.41848.stgit@localhost.localdomain> --0XkHs8j1o2DMM6L5262LlJIwn5VfrEH2u Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/02/16 20:41, Alan wrote: > From: Greg Hackmann >=20 > Add device tree bindings to the Goldfish frame buffer interface. >=20 > Signed-off-by: Greg Hackmann > Signed-off-by: Jin Qian > Signed-off-by: Alan Cox > --- > Documentation/devicetree/bindings/goldfish/fb.txt | 17 +++++++++++++= ++++ > drivers/video/fbdev/goldfishfb.c | 9 ++++++++- > 2 files changed, 25 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/goldfish/fb.txt Device tree bindings should also be sent to the devicetree mailing list. > diff --git a/Documentation/devicetree/bindings/goldfish/fb.txt b/Docume= ntation/devicetree/bindings/goldfish/fb.txt > new file mode 100644 > index 0000000..c7d2d46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/goldfish/fb.txt > @@ -0,0 +1,17 @@ > +Android Goldfish Framebuffer > + > +Andorid goldfish framebuffer device generated by android emulator. Typo there in Android. > + > +Required properties: > + > +- compatible : should contain "google,goldfish-fb" to match emulator > +- reg : > +- interrupts : > + > +Example: > + > + goldfish_fb@9010000 { > + compatible =3D "google,goldfish-fb"; > + reg =3D <0x9010000 0x100>; > + interrupts =3D <0x2>; > + }; > diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/gol= dfishfb.c > index 7f6c9e6..f0e651b 100644 > --- a/drivers/video/fbdev/goldfishfb.c > +++ b/drivers/video/fbdev/goldfishfb.c > @@ -304,12 +304,19 @@ static int goldfish_fb_remove(struct platform_dev= ice *pdev) > return 0; > } > =20 > +static const struct of_device_id goldfish_fb_of_match[] =3D { > + { .compatible =3D "google,goldfish-fb", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, goldfish_fb_of_match); > =20 > static struct platform_driver goldfish_fb_driver =3D { > .probe =3D goldfish_fb_probe, > .remove =3D goldfish_fb_remove, > .driver =3D { > - .name =3D "goldfish_fb" > + .name =3D "goldfish_fb", > + .owner =3D THIS_MODULE, > + .of_match_table =3D goldfish_fb_of_match, > } > }; > =20 >=20 --0XkHs8j1o2DMM6L5262LlJIwn5VfrEH2u-- --ClVIm2AiWOlI1EUhGqGk0etOfPia2te6M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW3ciBAAoJEPo9qoy8lh71GGoP/R5REm8om+oKfck1zfy+DuNl Bu9ywMQYJo290jVDnxoeo9mQmmYibJy1k7Rihq/s/tP9jOMei75kDdOSuJJ+UHAx YaLTVFBatA+r7lZmSFMv7Mtt05qJvK8XjPyCtKyFYmeoG67nMwk/Z+k7NTGqXH+Q MNH8Xc2rLz2GGUd7cX+nIKTCslFiZPRA5LWb8q83IXmFygJz6Iqz7f3PM8Iz03Zw WYDhMzaW37s1xcac6d+WQ58Oj9Dv91aOJFRN+m7GoI9WjlFriqwgsqfo2SGw4MXu K8r2W06qEXSlMoqeAr+QcwV0lrCqwaNCnjYRDbw33jz1Fjuw66FSt18iCN2F/lQr /0FQ+SZtx1vmHT7cAnRy0Hjwd9oUWEq9o/ElWFdIY+XMTpO22Oi38txcloTn3m8n y8IdeJGjHLscEnzvvX2hCdYa7wFxnAhgmU14EJZnJv7t83uFHFWFxZcCqp/6m3jq FNHw0/2ggSdULHat0D2FXhUo3mqhntZuuH268KBXNlbdXcpI+OfM/tO4JGceUy4v 7pF4eSR9Exm7RdwyIEyVy1XdLwyfNzuNtDXp168IkedpBjAZCLiXyan1/yvgCXRN TErlT/OzHmmAS9goTvclSWqOKvtIsQTTh5OSOGqnHv80P9e27lm0QX2QMAgdgnoF 7pw/NwWdtphzcFxPFsBq =rfKG -----END PGP SIGNATURE----- --ClVIm2AiWOlI1EUhGqGk0etOfPia2te6M--