Re: [PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1214 bytes --]


On 29/04/16 17:55, Daniel Vetter wrote:

>> Who's calling {write,fillrect,copyarea,imageblit} in an atomic context?
>> That sounds like a very bad idea to me...
>>
>> If this is only for accumulating changes, I think it may be better to
>> leave that to the driver as it may have better idea of how to accumulate.
>>
>> But, of course, this is a helper, so if all the drivers use this kind of
>> accumulation, it makes sense =).
> 
> Apparently panic context and cursor timer and stuff like that. I think
> this started with udl, and just to make sure (it's fbdev after all, no one
> wants to read the code itself) we've put those checks onto all entry
> points that draw stuff. It could be overkill, but this is what udl/qxl
> already do, so better to keep imo for now.
> 
> I guess if it's really not needed we could later on change that, but not
> sure that's worth the effort. And we can't get rid of it entirely.

Yep... Sounds fine to me.

Someone should implement (minimal) fbdev userspace API support to DRM
without using the current fbdev, and implement fbcon on top of that. I
don't like how DRM and fbdev gets mixed...

I offer a beer to anyone who does that =).

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]