From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/3] video: fbdev: imxfb: make it work again
Date: Tue, 10 May 2016 08:47:38 +0000 [thread overview]
Message-ID: <5731A02A.2070309@ti.com> (raw)
In-Reply-To: <1462354998-5792-1-git-send-email-u.kleine-koenig@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 773 bytes --]
Hi,
On 04/05/16 12:43, Uwe Kleine-König wrote:
> Hello,
>
> this is v2 of the series which addresses the review comments I got vor
> (implicit) v1.
>
> For patch 2 the question is still open if this is the right fix, but
> without this the display doesn't stay on. Patches 1 and 3 should be
> applicable independant of patch 2.
I picked patches 1 and 3, they look fine.
I still think patch 2 is just broken, it doesn't make sense to me.
If the regulator is enabled in probe, then it's always on, and
imxfb_lcd_set_power() should be removed as it never has any effect. But
that doesn't sound correct, as presumably the imxfb_lcd_set_power() has
worked at some point.
And shouldn't the regulator be disabled at least when suspending?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-10 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 9:43 [PATCH v2 0/3] video: fbdev: imxfb: make it work again Uwe Kleine-König
2016-05-04 9:43 ` [PATCH v2 1/3] video: fbdev: imxfb: fix semantic of .get_power and .set_power Uwe Kleine-König
2016-05-04 11:13 ` Philipp Zabel
2016-05-04 9:43 ` [PATCH v2 2/3] video: fbdev: imxfb: enable lcd regulator in .probe Uwe Kleine-König
2016-05-04 9:43 ` [PATCH v2 3/3] video: fbdev: imxfb: add some error handling Uwe Kleine-König
2016-05-10 8:47 ` Tomi Valkeinen [this message]
2016-05-10 9:05 ` [PATCH v2 0/3] video: fbdev: imxfb: make it work again Uwe Kleine-König
2016-05-10 10:06 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5731A02A.2070309@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).