From: Sui Jingfeng <15330273260@189.cn>
To: Thomas Zimmermann <tzimmermann@suse.de>,
deller@gmx.de, geert@linux-m68k.org, javierm@redhat.com,
daniel@ffwll.ch, vgupta@kernel.org, chenhuacai@kernel.org,
kernel@xen0n.name, davem@davemloft.net,
James.Bottomley@HansenPartnership.com, arnd@arndb.de,
sam@ravnborg.org
Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-m68k@lists.linux-m68k.org, loongarch@lists.linux.dev,
sparclinux@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v4,3/6] fbdev: Include <linux/io.h> in various drivers
Date: Thu, 4 May 2023 19:31:24 +0800 [thread overview]
Message-ID: <58d2bd17-3b51-bd24-2f30-d849d3f72b0e@189.cn> (raw)
In-Reply-To: <20230504074539.8181-4-tzimmermann@suse.de>
Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn>
On 2023/5/4 15:45, Thomas Zimmermann wrote:
> The code uses writel() and similar I/O-memory helpers. Include
> the header file to get the declarations.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/video/fbdev/arcfb.c | 1 +
> drivers/video/fbdev/aty/atyfb.h | 2 ++
> drivers/video/fbdev/wmt_ge_rops.c | 2 ++
> 3 files changed, 5 insertions(+)
>
> diff --git a/drivers/video/fbdev/arcfb.c b/drivers/video/fbdev/arcfb.c
> index 45e64016db32..d631d53f42ad 100644
> --- a/drivers/video/fbdev/arcfb.c
> +++ b/drivers/video/fbdev/arcfb.c
> @@ -41,6 +41,7 @@
> #include <linux/vmalloc.h>
> #include <linux/delay.h>
> #include <linux/interrupt.h>
> +#include <linux/io.h>
> #include <linux/fb.h>
> #include <linux/init.h>
> #include <linux/arcfb.h>
> diff --git a/drivers/video/fbdev/aty/atyfb.h b/drivers/video/fbdev/aty/atyfb.h
> index 465f55beb97f..30da3e82ed3c 100644
> --- a/drivers/video/fbdev/aty/atyfb.h
> +++ b/drivers/video/fbdev/aty/atyfb.h
> @@ -3,8 +3,10 @@
> * ATI Frame Buffer Device Driver Core Definitions
> */
>
> +#include <linux/io.h>
> #include <linux/spinlock.h>
> #include <linux/wait.h>
> +
> /*
> * Elements of the hardware specific atyfb_par structure
> */
> diff --git a/drivers/video/fbdev/wmt_ge_rops.c b/drivers/video/fbdev/wmt_ge_rops.c
> index 42255d27a1db..99c7b0aea615 100644
> --- a/drivers/video/fbdev/wmt_ge_rops.c
> +++ b/drivers/video/fbdev/wmt_ge_rops.c
> @@ -9,7 +9,9 @@
>
> #include <linux/module.h>
> #include <linux/fb.h>
> +#include <linux/io.h>
> #include <linux/platform_device.h>
> +
> #include "core/fb_draw.h"
> #include "wmt_ge_rops.h"
>
next prev parent reply other threads:[~2023-05-04 11:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 7:45 [PATCH v4 0/6] fbdev: Move framebuffer I/O helpers to <asm/fb.h> Thomas Zimmermann
2023-05-04 7:45 ` [PATCH v4 1/6] fbdev/matrox: Remove trailing whitespaces Thomas Zimmermann
2023-05-04 11:25 ` [v4,1/6] " Sui Jingfeng
2023-05-04 7:45 ` [PATCH v4 2/6] ipu-v3: Include <linux/io.h> Thomas Zimmermann
2023-05-04 11:30 ` [v4,2/6] " Sui Jingfeng
2023-05-04 7:45 ` [PATCH v4 3/6] fbdev: Include <linux/io.h> in various drivers Thomas Zimmermann
2023-05-04 11:31 ` Sui Jingfeng [this message]
2023-05-04 7:45 ` [PATCH v4 4/6] fbdev: Include <linux/fb.h> instead of <asm/fb.h> Thomas Zimmermann
2023-05-04 11:34 ` [v4,4/6] " Sui Jingfeng
2023-05-04 15:37 ` [PATCH v4 4/6] " Sam Ravnborg
2023-05-05 7:02 ` Thomas Zimmermann
2023-05-04 7:45 ` [PATCH v4 5/6] fbdev: Move framebuffer I/O helpers into <asm/fb.h> Thomas Zimmermann
2023-05-04 11:59 ` [v4,5/6] " Sui Jingfeng
2023-05-05 6:59 ` Thomas Zimmermann
2023-05-04 7:45 ` [PATCH v4 6/6] fbdev: Rename fb_mem*() helpers Thomas Zimmermann
2023-05-04 11:33 ` [v4,6/6] " Sui Jingfeng
2023-05-04 8:08 ` [PATCH v4 0/6] fbdev: Move framebuffer I/O helpers to <asm/fb.h> Arnd Bergmann
2023-05-05 7:01 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58d2bd17-3b51-bd24-2f30-d849d3f72b0e@189.cn \
--to=15330273260@189.cn \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).