From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84117C7EE26 for ; Thu, 4 May 2023 11:31:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229756AbjEDLba (ORCPT ); Thu, 4 May 2023 07:31:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229606AbjEDLb3 (ORCPT ); Thu, 4 May 2023 07:31:29 -0400 Received: from 189.cn (ptr.189.cn [183.61.185.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2276B3C0F; Thu, 4 May 2023 04:31:28 -0700 (PDT) HMM_SOURCE_IP: 10.64.8.31:55282.482502416 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-114.242.206.180 (unknown [10.64.8.31]) by 189.cn (HERMES) with SMTP id 40663100283; Thu, 4 May 2023 19:31:24 +0800 (CST) Received: from ([114.242.206.180]) by gateway-151646-dep-85667d6c59-6qwzn with ESMTP id 70d89bba14af4bc3806cb9bbf0733f71 for tzimmermann@suse.de; Thu, 04 May 2023 19:31:27 CST X-Transaction-ID: 70d89bba14af4bc3806cb9bbf0733f71 X-Real-From: 15330273260@189.cn X-Receive-IP: 114.242.206.180 X-MEDUSA-Status: 0 Sender: 15330273260@189.cn Message-ID: <58d2bd17-3b51-bd24-2f30-d849d3f72b0e@189.cn> Date: Thu, 4 May 2023 19:31:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [v4,3/6] fbdev: Include in various drivers Content-Language: en-US To: Thomas Zimmermann , deller@gmx.de, geert@linux-m68k.org, javierm@redhat.com, daniel@ffwll.ch, vgupta@kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, davem@davemloft.net, James.Bottomley@HansenPartnership.com, arnd@arndb.de, sam@ravnborg.org Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-m68k@lists.linux-m68k.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20230504074539.8181-4-tzimmermann@suse.de> From: Sui Jingfeng <15330273260@189.cn> In-Reply-To: <20230504074539.8181-4-tzimmermann@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Reviewed-by: Sui Jingfeng On 2023/5/4 15:45, Thomas Zimmermann wrote: > The code uses writel() and similar I/O-memory helpers. Include > the header file to get the declarations. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Sam Ravnborg > --- > drivers/video/fbdev/arcfb.c | 1 + > drivers/video/fbdev/aty/atyfb.h | 2 ++ > drivers/video/fbdev/wmt_ge_rops.c | 2 ++ > 3 files changed, 5 insertions(+) > > diff --git a/drivers/video/fbdev/arcfb.c b/drivers/video/fbdev/arcfb.c > index 45e64016db32..d631d53f42ad 100644 > --- a/drivers/video/fbdev/arcfb.c > +++ b/drivers/video/fbdev/arcfb.c > @@ -41,6 +41,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/video/fbdev/aty/atyfb.h b/drivers/video/fbdev/aty/atyfb.h > index 465f55beb97f..30da3e82ed3c 100644 > --- a/drivers/video/fbdev/aty/atyfb.h > +++ b/drivers/video/fbdev/aty/atyfb.h > @@ -3,8 +3,10 @@ > * ATI Frame Buffer Device Driver Core Definitions > */ > > +#include > #include > #include > + > /* > * Elements of the hardware specific atyfb_par structure > */ > diff --git a/drivers/video/fbdev/wmt_ge_rops.c b/drivers/video/fbdev/wmt_ge_rops.c > index 42255d27a1db..99c7b0aea615 100644 > --- a/drivers/video/fbdev/wmt_ge_rops.c > +++ b/drivers/video/fbdev/wmt_ge_rops.c > @@ -9,7 +9,9 @@ > > #include > #include > +#include > #include > + > #include "core/fb_draw.h" > #include "wmt_ge_rops.h" >