Re: [PATCH] staging: sm750: rename CamelCase variable in sm750.c

["M.samet Duman" <dumanmehmetsamet@icloud.com>]

Not a change that will set the world on fire.

--
Samet

> 2026. 5. 15. 오후 2:46, Ahmet Sezgin Duran <ahmet@sezginduran.net> 작성:
> 
> On 5/15/26 1:38 PM, Rupesh Majhi wrote:
>> Renamed the following CamelCase variables to snake_case to comply
>> with Linux kernel coding style:
>> - pvReg -> pv_reg
>> - setAllEngOff -> set_all_eng_off
>> Issue found by checkpatch.
>> Signed-off-by: Rupesh Majhi <zoone.rupert@gmail.com>
>> ---
>>  drivers/staging/sm750fb/sm750.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
>> index 996a586a3727..9b30627a19d0 100644
>> --- a/drivers/staging/sm750fb/sm750.c
>> +++ b/drivers/staging/sm750fb/sm750.c
>> @@ -755,7 +755,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
>>       * must be set after crtc member initialized
>>       */
>>      crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024;
>> -    crtc->cursor.mmio = sm750_dev->pvReg +
>> +    crtc->cursor.mmio = sm750_dev->pv_reg +
>>          0x800f0 + (int)crtc->channel * 0x140;
>>        crtc->cursor.max_h = 64;
>> @@ -860,7 +860,7 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
>>      sm750_dev->init_parm.mem_clk = 0;
>>      sm750_dev->init_parm.master_clk = 0;
>>      sm750_dev->init_parm.power_mode = 0;
>> -    sm750_dev->init_parm.setAllEngOff = 0;
>> +    sm750_dev->init_parm.set_all_eng_off = 0;
>>      sm750_dev->init_parm.reset_memory = 1;
>>        /* defaultly turn g_hwcursor on for both view */
>> @@ -1059,7 +1059,7 @@ static void lynxfb_pci_remove(struct pci_dev *pdev)
>>      sm750fb_framebuffer_release(sm750_dev);
>>      arch_phys_wc_del(sm750_dev->mtrr.vram);
>>  -    iounmap(sm750_dev->pvReg);
>> +    iounmap(sm750_dev->pv_reg);
>>      iounmap(sm750_dev->vmem);
>>      pci_release_region(pdev, 1);
>>      kfree(g_settings);
> 
> Did you compile this patch?
> 
> Regards,
> Ahmet Sezgin Duran
>