From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michal Januszewski" Subject: Re: [Linux-fbdev-devel] [PATCH] drivers: process failure of sysfs_create_group() Date: Tue, 11 Nov 2008 11:05:15 +0100 Message-ID: <5d9b736f0811110205q719ad246t81cc00fd9997b10@mail.gmail.com> References: <20081110105332.GA19358@ubuntu> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Geert Uytterhoeven Cc: Jianjun Kong , linux-fbdev-devel@lists.sourceforge.net, Linux-Kernel-Mailing-List On Mon, Nov 10, 2008 at 22:30, Geert Uytterhoeven wrote: >> When fail to call sysfs_create_group(), it should recycle resources and return the error. >> This patch fix for processing failure of sysfs_create_group(). > > IIRC, the reasoning behind the current code is that a failure to create sysfs > entries is not critical, as it doesn't impact the correct functioning of the > core of the driver. That's correct -- that was exactly my reasoning behind this code. -- Michal Januszewski, Gentoo Linux Developer http://people.gentoo.org/spock