From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Mon, 06 Nov 2017 09:00:25 +0000 Subject: Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init() Message-Id: <5e11db02-618e-ac60-921f-2971458a4484@users.sourceforge.net> List-Id: References: <2db677d2-ad4e-1f79-344b-dfa38ce948c9@users.sourceforge.net> <5477205e-2067-de4f-8736-71a2c9dc1653@microchip.com> <20171106085329.szz2ocu5d2iurlov@mwanda> In-Reply-To: <20171106085329.szz2ocu5d2iurlov@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: LKML , kernel-janitors@vger.kernel.org, Nicolas Ferre , Bartlomiej Zolnierkiewicz >> If you want to lower the size of strings in this driver, you can do it, >> but not like this. > > Just so we're clear, GCC already detects and combines it when you use > the same string constant twice. Do you distinguish between merging of constants and the combination of statements for such an use case? Regards, Markus