From: Helge Deller <deller@gmx.de>
To: arnd@arndb.de, b.zolnierkie@samsung.com, robert.jarzmik@free.fr,
ulf.hansson@linaro.org, wangqing@vivo.com
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err()
Date: Mon, 7 Nov 2022 09:52:35 +0100 [thread overview]
Message-ID: <5e52528f-e4a7-0aa5-b795-0cff80a153ce@gmx.de> (raw)
In-Reply-To: <278d64e0.bd.1844d4c7a95.Coremail.wangkailong@jari.cn>
On 11/6/22 15:16, wangkailong@jari.cn wrote:
> Eliminate the follow coccicheck warning:
>
> ./drivers/video/fbdev/pxafb.c:2330:2-9: line 2330 is redundant because
> platform_get_irq() already prints an error
>
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/pxafb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index 696ac5431180..c46ed78298ae 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -2327,7 +2327,6 @@ static int pxafb_probe(struct platform_device *dev)
>
> irq = platform_get_irq(dev, 0);
> if (irq < 0) {
> - dev_err(&dev->dev, "no IRQ defined\n");
> ret = -ENODEV;
> goto failed_free_mem;
> }
prev parent reply other threads:[~2022-11-07 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 14:16 [PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err() wangkailong
2022-11-07 8:52 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e52528f-e4a7-0aa5-b795-0cff80a153ce@gmx.de \
--to=deller@gmx.de \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=ulf.hansson@linaro.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox