Re: [PATCH v2 1/2] fbdev: ssd1307fb: add support for Sino Wealth SH1107 controller

[Helge Deller <deller@gmx.de>]

Hello Javier,

On 8/1/26 20:11, Javier Martinez Canillas wrote:
> Helge Deller <deller@gmx.de> writes:
>> On 7/31/26 16:45, Jakub Turek wrote:
>>> The SH1107 display controller is very similar to SSD1307 but the main
>>> difference is that SH1107 has different memory layout and uses page mode
>>> adressation only.
>>>
>>> The SH1107 relies primarily on vertical page addressing mode where the
>>> internal 128x128 GDDRAM is split into 16 vertical pages, rather than
>>> the horizontal/tile addressing modes natively utilized by the
>>> SSD1306/SSD1307.
>>>
>>> Signed-off-by: Jakub Turek <jakub.turek@elsta.tech>
>>> ---
>>>    drivers/video/fbdev/ssd1307fb.c | 87 +++++++++++++++++++++++++++++++++++------
>>>    1 file changed, 76 insertions(+), 11 deletions(-)
>> series applied.
>>
> 
> Why did you apply the series? I mentioned in v1 that Jakub instead should
> use the KMS ssd130x driver that already support variants that use page
> addressing, such as the SH1106 (adding SSH1107 should be trivial).

I assume, that Jakub or someone else will send a patch for the KMS driver. 
> Also, Sashiko correctly pointed out that the fbdev driver doesn't support
> most of the properties mentioned in the DT binding schema.
> 
> Now is the opposite given that you merged the DT binding patch. The ssd130x
> driver doesn't have support for the "sinowealth,sh1107" compatible string
> that is being added by patch 2/2.
Ah, ok.
To avoid issues, I've dropped the patch for now.

Thanks!
Helge