From: Daniel Thompson <daniel.thompson@linaro.org>
To: Colin King <colin.king@canonical.com>,
Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-fbdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backlight: s6e63m0: make const arrays static, reduces object code size
Date: Tue, 12 Sep 2017 13:12:04 +0000 [thread overview]
Message-ID: <5f9c04a8-8162-8ddd-caf2-e734a14a2ee3@linaro.org> (raw)
In-Reply-To: <20170912114545.2131-1-colin.king@canonical.com>
On 12/09/17 12:45, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrays on the stack, instead make them
> static. Makes the object code smaller by nearly 400 bytes:
>
> Before:
> text data bss dec hex filename
> 15164 6336 0 21500 53fc drivers/video/backlight/s6e63m0.o
>
> After:
> text data bss dec hex filename
> 14669 6432 0 21101 526d drivers/video/backlight/s6e63m0.o
For future records, can you record the compiler version, architecture
and optimization level (-O2 or -Os) to the patch header?
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/video/backlight/s6e63m0.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
> index 3c4a22a3063a..965c660b2f6b 100644
> --- a/drivers/video/backlight/s6e63m0.c
> +++ b/drivers/video/backlight/s6e63m0.c
> @@ -446,7 +446,7 @@ static int s6e63m0_gamma_ctl(struct s6e63m0 *lcd, int gamma)
> static int s6e63m0_ldi_init(struct s6e63m0 *lcd)
> {
> int ret, i;
> - const unsigned short *init_seq[] = {
> + static const unsigned short *init_seq[] = {
I'd be inclined to throw in an extra const to help the compile spot any
negligent maintenance in the future:
static const unsigned short * const init_seq[];
> seq_panel_condition_set,
> seq_display_condition_set,
> seq_gamma_setting,
> @@ -467,7 +467,7 @@ static int s6e63m0_ldi_init(struct s6e63m0 *lcd)
> static int s6e63m0_ldi_enable(struct s6e63m0 *lcd)
> {
> int ret = 0, i;
> - const unsigned short *enable_seq[] = {
> + static const unsigned short *enable_seq[] = {
> seq_stand_by_off,
> seq_display_on,
> };
>
prev parent reply other threads:[~2017-09-12 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 11:45 [PATCH] backlight: s6e63m0: make const arrays static, reduces object code size Colin King
2017-09-12 13:12 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f9c04a8-8162-8ddd-caf2-e734a14a2ee3@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=colin.king@canonical.com \
--cc=jingoohan1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox