From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: ChiaEn Wu <peterwu.pub@gmail.com>,
lee.jones@linaro.org, daniel.thompson@linaro.org,
jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
sre@kernel.org, chunfeng.yun@mediatek.com,
gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de,
lgirdwood@gmail.com, broonie@kernel.org, linux@roeck-us.net,
heikki.krogerus@linux.intel.com, deller@gmx.de
Cc: cy_huang@richtek.com, alice_chen@richtek.com,
chiaen_wu@richtek.com, dri-devel@lists.freedesktop.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 13/14] dt-bindings: backlight: Add Mediatek MT6370 backlight binding documentation
Date: Wed, 1 Jun 2022 09:34:54 +0200 [thread overview]
Message-ID: <6227bc72-fe7c-561a-073d-bd5e6debc68f@linaro.org> (raw)
In-Reply-To: <20220531102809.11976-14-peterwu.pub@gmail.com>
On 31/05/2022 12:28, ChiaEn Wu wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Add mt6370 backlight binding documentation.
>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> .../backlight/mediatek,mt6370-backlight.yaml | 110 ++++++++++++++++++
> 1 file changed, 110 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
> new file mode 100644
> index 000000000000..81d72ed44be4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/mediatek,mt6370-backlight.yaml
> @@ -0,0 +1,110 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/mediatek,mt6370-backlight.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek MT6370 Backlight
> +
> +maintainers:
> + - ChiaEn Wu <chiaen_wu@richtek.com>
> +
> +description: |
> + MT6370 is a highly-integrated smart power management IC, which includes a
> + single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C &
> + Power Delivery (PD) controller, dual flash LED current sources, a RGB LED
> + driver, a backlight WLED driver, a display bias driver and a general LDO for
> + portable devices.
Do not repeat entire device description, but describe only this part.
Your other pieces of MFD were doing it correctly, so why here it is
different?
> +
> + For the LCD backlight, it can provide 4 channel WLED driving capability.
> + Each channel driving current is up to 30mA
> +
> +allOf:
> + - $ref: common.yaml#
> +
> +properties:
> + compatible:
> + const: mediatek,mt6370-backlight
> +
> + default-brightness:
> + minimum: 0
> + maximum: 2048
> +
> + max-brightness:
> + minimum: 0
> + maximum: 2048
> +
> + enable-gpios:
> + description: External backlight 'enable' pin
> + maxItems: 1
> +
> + mediatek,bled-pwm-enable:
> + description: |
> + Enable external PWM input for backlight dimming
> + type: boolean
> +
> + mediatek,bled-pwm-hys-enable:
> + description: |
> + Enable the backlight input-hysteresis for PWM mode
> + type: boolean
> +
> + mediatek,bled-pwm-hys-sel:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + enum: [0, 1, 2, 3]
> + description: |
> + Backlight PWM hysteresis input level selection.
> + value mapping:
> + - 0: 1bit
> + - 1: 2bit
> + - 2: 4bit
> + - 3: 6bit
Please explain what is this input level and what is the meaning of
6bit... In any case you cannot have values mapping, but instead you
should use the logical values (so 1, 2, 4, and 6).
If "sel" is shortcut of "selection" please drop it.
> +
> + mediatek,bled-ovp-shutdown:
> + description: |
> + Enable the backlight shutdown when OVP level triggered
> + type: boolean
> +
> + mediatek,bled-ovp-level-sel:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + enum: [0, 1, 2, 3]
> + description: |
> + Backlight OVP level selection.
> + value mapping:
> + - 0: 17V
> + - 1: 21V
> + - 2: 25V
> + - 3: 29V
Logical values in microvolts. Name it according to unit suffices and
drop any useless parts of property name like "level selection". It is
simply - mediatek,bled-ovp-microvolt.
> +
> + mediatek,bled-ocp-shutdown:
> + description: |
> + Enable the backlight shutdown when OCP level triggerred.
> + type: boolean
> +
> + mediatek,bled-ocp-level-sel:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + enum: [0, 1, 2, 3]
> + description: |
> + Backlight OC level selection.
> + value mapping:
> + - 0: 900mA
> + - 1: 1200mA
> + - 2: 1500mA
> + - 3: 1800mA
Same comments.
> +
> + mediatek,bled-channel-use:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description: |
> + Backlight LED channel to be used.
> + Each bit mapping to:
> + - 0: CH4
> + - 1: CH3
> + - 2: CH2
> + - 3: CH1> + minimum: 1
> + maximum: 15
> +
> +required:
> + - compatible
> + - mediatek,bled-channel-use
> +
> +additionalProperties: false
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-01 7:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 10:27 [PATCH 00/14] Add Mediatek MT6370 PMIC support ChiaEn Wu
2022-05-31 10:27 ` [PATCH 01/14] mfd: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-05-31 10:27 ` [PATCH 02/14] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver ChiaEn Wu
2022-05-31 10:27 ` [PATCH 03/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support ChiaEn Wu
2022-05-31 12:41 ` Mark Brown
2022-05-31 10:27 ` [PATCH 04/14] iio: adc: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-05-31 10:28 ` [PATCH 05/14] power: supply: mt6370: Add Mediatek MT6370 charger driver ChiaEn Wu
2022-05-31 10:28 ` [PATCH 06/14] leds: mt6370: Add Mediatek MT6370 Indicator support ChiaEn Wu
2022-06-01 9:48 ` Andy Shevchenko
2022-06-01 9:51 ` Andy Shevchenko
2022-06-02 6:26 ` ChiYuan Huang
2022-06-02 9:17 ` Andy Shevchenko
2022-06-02 9:35 ` ChiYuan Huang
2022-05-31 10:28 ` [PATCH 07/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support ChiaEn Wu
2022-06-01 9:57 ` Andy Shevchenko
2022-06-02 12:07 ` szuni chen
2022-06-02 13:57 ` Andy Shevchenko
2022-06-02 13:59 ` Andy Shevchenko
2022-05-31 10:28 ` [PATCH 08/14] video: backlight: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-05-31 10:28 ` [PATCH 09/14] dt-bindings: usb: Add Mediatek MT6370 TCPC binding documentation ChiaEn Wu
2022-06-01 7:26 ` Krzysztof Kozlowski
2022-05-31 10:28 ` [PATCH 10/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger " ChiaEn Wu
2022-05-31 10:28 ` [PATCH 11/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 indicator documentation ChiaEn Wu
2022-05-31 10:28 ` [PATCH 12/14] dt-bindings: leds: Add Mediatek MT6370 flashlight binding documentation ChiaEn Wu
2022-05-31 10:28 ` [PATCH 13/14] dt-bindings: backlight: Add Mediatek MT6370 backlight " ChiaEn Wu
2022-06-01 7:34 ` Krzysztof Kozlowski [this message]
2022-05-31 10:28 ` [PATCH 14/14] dt-bindings: mfd: Add Mediatek MT6370 " ChiaEn Wu
2022-05-31 20:46 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2022-05-31 10:42 [PATCH 09/14] dt-bindings: usb: Add Mediatek MT6370 TCPC " ChiaEn Wu
2022-05-31 10:42 ` [PATCH 13/14] dt-bindings: backlight: Add Mediatek MT6370 backlight " ChiaEn Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6227bc72-fe7c-561a-073d-bd5e6debc68f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alice_chen@richtek.com \
--cc=broonie@kernel.org \
--cc=chiaen_wu@richtek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).