linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] fbdev: remove "default y" from FB_SH_MOBILE_MERAM
Date: Mon, 05 Mar 2012 15:11:27 +0000	[thread overview]
Message-ID: <6558972.58UQFYlcLG@avalon> (raw)
In-Reply-To: <874nu7bcd3.wl%kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

Thanks for the patch.

On Friday 02 March 2012 01:06:53 Kuninori Morimoto wrote:
> "default y" of FB_SH_MOBILE_MERAM was overkill option.
> "depends on FB_SH_MOBILE_LCDC" is very enough here.

Actually the sh_mobile_meram driver doesn't depend on the LCDC driver. What 
would you think about removing both the dependency and the default=y ?

> This patch remove it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  drivers/video/Kconfig |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 549b960..dfec9b7 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -1994,7 +1994,6 @@ config FB_SH_MOBILE_HDMI
>  config FB_SH_MOBILE_MERAM
>  	tristate "SuperH Mobile MERAM read ahead support for LCDC"
>  	depends on FB_SH_MOBILE_LCDC
> -	default y
>  	---help---
>  	  Enable MERAM support for the SH-Mobile LCD controller.

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2012-03-05 15:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02  9:06 [PATCH] fbdev: remove "default y" from FB_SH_MOBILE_MERAM Kuninori Morimoto
2012-03-05 15:11 ` Laurent Pinchart [this message]
2012-03-05 22:59 ` Takanari Hayama
2012-03-06  0:12 ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6558972.58UQFYlcLG@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).