From: Helge Deller <deller@gmx.de>
To: cgel.zte@gmail.com, s.hauer@pengutronix.de, kernel@pengutronix.de
Cc: shawnguo@kernel.org, festevam@gmail.com, linux-imx@nxp.com,
linux-fbdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Lv Ruyi <lv.ruyi@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] video: fbdev: Fix missing of_node_put in imxfb_probe
Date: Thu, 7 Apr 2022 21:41:16 +0200 [thread overview]
Message-ID: <67698385-b2fe-2de9-9775-9f6320a0e9e3@gmx.de> (raw)
In-Reply-To: <20220407090122.2491922-1-lv.ruyi@zte.com.cn>
On 4/7/22 11:01, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> of_parse_phandle returns node pointer with refcount incremented,
> use of_node_put() on it when done.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/imxfb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
> index 68288756ffff..a2f644c97f28 100644
> --- a/drivers/video/fbdev/imxfb.c
> +++ b/drivers/video/fbdev/imxfb.c
> @@ -925,10 +925,12 @@ static int imxfb_probe(struct platform_device *pdev)
> sizeof(struct imx_fb_videomode), GFP_KERNEL);
> if (!fbi->mode) {
> ret = -ENOMEM;
> + of_node_put(display_np);
> goto failed_of_parse;
> }
>
> ret = imxfb_of_read_mode(&pdev->dev, display_np, fbi->mode);
> + of_node_put(display_np);
> if (ret)
> goto failed_of_parse;
> }
prev parent reply other threads:[~2022-04-07 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 9:01 [PATCH] video: fbdev: Fix missing of_node_put in imxfb_probe cgel.zte
2022-04-07 19:41 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67698385-b2fe-2de9-9775-9f6320a0e9e3@gmx.de \
--to=deller@gmx.de \
--cc=cgel.zte@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox